Add additional non-sparse tests (#112)

* Add additional non-sparse tests

* Test non-sparse snapshot replication

* Add non-sparse partial snapshot test

* Adjust assertions

* Feedback from @mafintosh

* non sparse snaphots should be upgraded contig length changes as well

* Correct assertion

* Check update after snapshot

* fix upgraded going to false on non-sparse in edgecases

Co-authored-by: Mathias Buus <[email protected]>

Author: kasperisager

index.js

@@ -589,14 +589,17 @@ module.exports = class Hypercore extends EventEmitter {
     const activeRequests = (opts && opts.activeRequests) || this.activeRequests
     const req = this.replicator.addUpgrade(activeRequests)
 
-    const upgraded = await req.promise
+    let upgraded = await req.promise
 
     if (!this.sparse) {
       // Download all available blocks in non-sparse mode
       const start = this.length
       const end = this.core.tree.length
+      const contig = this.contiguousLength
 
       await this.download({ start, end, ifAvailable: true }).downloaded()
+
+      if (!upgraded) upgraded = this.contiguousLength !== contig
     }
 
     if (!upgraded) return false

test/replicate.js

@@ -736,5 +736,48 @@ test('download available blocks on non-sparse update', async function (t) {
   await a.append(['a', 'b', 'c', 'd', 'e'])
   await b.update()
 
-  t.is(b.contiguousLength, 5)
+  t.is(b.contiguousLength, b.length)
+})
+
+test('non-sparse snapshot during replication', async function (t) {
+  const a = await create()
+  const b = await create(a.key, { sparse: false })
+
+  replicate(a, b, t)
+
+  await a.append(['a', 'b', 'c', 'd', 'e'])
+  await b.update()
+
+  const s = b.snapshot()
+
+  await a.append(['f', 'g', 'h', 'i', 'j'])
+  await s.update()
+
+  t.is(s.contiguousLength, s.length)
+})
+
+test('non-sparse snapshot during partial replication', async function (t) {
+  const a = await create()
+  const b = await create(a.key)
+  const c = await create(a.key, { sparse: false })
+
+  replicate(a, b, t)
+  replicate(b, c, t)
+
+  await a.append(['a', 'b', 'c', 'd', 'e'])
+
+  await b.download({ start: 0, end: 3 }).downloaded()
+  await c.update()
+
+  const s = c.snapshot()
+  t.is(s.contiguousLength, s.length)
+
+  await s.update()
+  t.is(s.contiguousLength, s.length)
+
+  await b.download({ start: 3, end: 5 }).downloaded()
+  t.is(s.contiguousLength, s.length)
+
+  await s.update()
+  t.is(s.contiguousLength, s.length)
 })

test/sessions.js

@@ -2,6 +2,7 @@ const test = require('brittle')
 const ram = require('random-access-memory')
 const crypto = require('hypercore-crypto')
 const codecs = require('codecs')
+const { create } = require('./helpers')
 
 const Hypercore = require('../')
 
@@ -212,3 +213,10 @@ test('sessions - custom preload hook on first/later sessions', async function (t
 
   await preloadsTest
 })
+
+test('session inherits non-sparse setting', async function (t) {
+  const a = await create({ sparse: false })
+  const s = a.session()
+
+  t.is(s.sparse, false)
+})