Add a catch to reduceAndConfigure in session cleanup

andrewosh · andrewosh · commit 290703789510 · 2020-09-16T14:06:07.000+02:00
diff --git a/lib/sessions/network.js b/lib/sessions/network.js
@@ -82,7 +82,8 @@ module.exports = class NetworkSession {
       this._sessionState.addResource('@network/configuration-' + dkeyString, null, () => {
         states.delete(this._sessionState)
         if (!states.size) this._networkStates.delete(dkeyString)
-        if (!this._networker.closed) reduceAndConfigure(false)
+        // reduceAndConfigure might fail here, but this is a sync cleanup function so the error is unimportant.
+        if (!this._networker.closed) reduceAndConfigure(false).catch(() => {})
       })
     }
 

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,8 @@ module.exports = class NetworkSession {`
`82`	`82`	`this._sessionState.addResource('@network/configuration-' + dkeyString, null, () => {`
`83`	`83`	`states.delete(this._sessionState)`
`84`	`84`	`if (!states.size) this._networkStates.delete(dkeyString)`
`85`		`- if (!this._networker.closed) reduceAndConfigure(false)`
	`85`	`+ // reduceAndConfigure might fail here, but this is a sync cleanup function so the error is unimportant.`
	`86`	`+ if (!this._networker.closed) reduceAndConfigure(false).catch(() => {})`
`86`	`87`	`})`
`87`	`88`	`}`
`88`	`89`