fix some deepsource warnings

Author: hyperdefined

src/main/java/lol/hyper/customlauncher/fieldofficetracker/FieldOffice.java

@@ -17,6 +17,7 @@
 
 package lol.hyper.customlauncher.fieldofficetracker;
 
+import lol.hyper.customlauncher.invasiontracker.Invasion;
 import org.jetbrains.annotations.NotNull;
 
 public class FieldOffice implements Comparable<FieldOffice> {
@@ -95,13 +96,24 @@ public void setTotalAnnexes(int totalAnnexes) {
 
     @Override
     public int compareTo(@NotNull FieldOffice fieldOffice) {
-        return (FieldOfficeTracker.zonesToStreets
-                .get(area)
-                .compareTo(FieldOfficeTracker.zonesToStreets.get(fieldOffice.getArea())));
+        return Integer.compare(this.area, fieldOffice.area);
     }
 
     @Override
     public String toString() {
         return FieldOfficeTracker.zonesToStreets.get(area);
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == this) {
+            return true;
+        }
+
+        if (!(o instanceof FieldOffice fieldOffice)) {
+            return false;
+        }
+
+        return fieldOffice.getArea() == this.getArea();
+    }
 }

src/main/java/lol/hyper/customlauncher/invasiontracker/Invasion.java

@@ -85,4 +85,17 @@ public String toString() {
     public int compareTo(Invasion invasion) {
         return (this.getDistrict().compareTo(invasion.getDistrict()));
     }
+
+    @Override
+    public boolean equals(Object o) {
+        if (o == this) {
+            return true;
+        }
+
+        if (!(o instanceof Invasion invasion)) {
+            return false;
+        }
+
+        return invasion.getDistrict().equals(this.getDistrict());
+    }
 }

src/main/java/lol/hyper/customlauncher/login/LoginHandler.java

@@ -34,9 +34,12 @@
 import org.json.JSONObject;
 
 import javax.swing.*;
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
 public class LoginHandler {
@@ -149,26 +152,47 @@ private void handleLoginRequest(LoginRequest loginRequest) {
      *
      * @param loginRequest The login request to process.
      * @return The login request that is sent back.
-     * @throws Exception Throws any errors about reading/sending data.
      */
-    private LoginRequest sendRequest(LoginRequest loginRequest) throws Exception {
+    private LoginRequest sendRequest(LoginRequest loginRequest) {
         HttpPost post = new HttpPost(REQUEST_URL);
         post.setHeader("User-Agent", Main.userAgent);
         post.setHeader("Content-type", "application/x-www-form-urlencoded");
 
         List<NameValuePair> urlParameters = new ArrayList<>();
-        for (String x : loginRequest.getRequestDetails().keySet()) {
-            urlParameters.add(new BasicNameValuePair(x, loginRequest.getRequestDetails().get(x)));
+        logger.info(loginRequest.getRequestDetails());
+        for (Map.Entry<String, String> entry : loginRequest.getRequestDetails().entrySet()) {
+            urlParameters.add(new BasicNameValuePair(entry.getKey(), entry.getValue()));
         }
 
-        post.setEntity(new UrlEncodedFormEntity(urlParameters));
+        try {
+            post.setEntity(new UrlEncodedFormEntity(urlParameters));
+        } catch (UnsupportedEncodingException exception) {
+            logger.error("Unable to send login request!", exception);
+            JFrame errorWindow = new ErrorWindow(null, exception);
+            errorWindow.dispose();
+            return null;
+        }
 
         String responseData;
 
-        try (CloseableHttpClient httpClient = HttpClients.createDefault();
-                CloseableHttpResponse response = httpClient.execute(post)) {
+        CloseableHttpClient httpClient = HttpClients.createDefault();
+        CloseableHttpResponse response = null;
+        try {
+            response = httpClient.execute(post);
+        } catch (IOException exception) {
+            logger.error("Unable to send login request!", exception);
+            JFrame errorWindow = new ErrorWindow(null, exception);
+            errorWindow.dispose();
+            return null;
+        }
 
+        try {
             responseData = EntityUtils.toString(response.getEntity());
+        } catch (IOException exception) {
+            logger.error("Unable to send login request!", exception);
+            JFrame errorWindow = new ErrorWindow(null, exception);
+            errorWindow.dispose();
+            return null;
         }
         JSONObject responseJSON = new JSONObject(responseData);
         LoginRequest newLogin = new LoginRequest();

src/main/java/lol/hyper/customlauncher/ttrupdater/TTRUpdater.java

@@ -45,10 +45,8 @@
 import java.nio.file.Paths;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
-import java.util.ArrayList;
+import java.util.*;
 import java.util.List;
-import java.util.Locale;
-import java.util.Objects;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;