hopefully fixed long standing bug

Author: hyperdefined

src/main/java/lol/hyper/toolstats/events/BlocksMined.java

@@ -70,17 +70,18 @@ private void updateBlocksMined(ItemStack itemStack) {
         }
         // read the current stats from the item
         // if they don't exist, then start from 0
-        Integer blocksMined = 0;
+        Integer blocksMined = null;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.genericMined, PersistentDataType.INTEGER)) {
             blocksMined = container.get(toolStats.genericMined, PersistentDataType.INTEGER);
         }
         if (blocksMined == null) {
-            return;
-        } else {
-            blocksMined++;
+            blocksMined = 0;
         }
+
+        blocksMined++;
         container.set(toolStats.genericMined, PersistentDataType.INTEGER, blocksMined);
+
         String configLore = toolStats.getLoreFromConfig("blocks-mined", false);
         String configLoreRaw = toolStats.getLoreFromConfig("blocks-mined", true);
 

src/main/java/lol/hyper/toolstats/events/EntityDamage.java

@@ -201,16 +201,16 @@ private ItemStack updatePlayerKills(ItemStack itemStack) {
         if (meta == null) {
             return null;
         }
-        Integer playerKills = 0;
+        Integer playerKills = null;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.swordPlayerKills, PersistentDataType.INTEGER)) {
             playerKills = container.get(toolStats.swordPlayerKills, PersistentDataType.INTEGER);
         }
         if (playerKills == null) {
-            return null;
-        } else {
-            playerKills++;
+            playerKills = 0;
         }
+
+        playerKills++;
         container.set(toolStats.swordPlayerKills, PersistentDataType.INTEGER, playerKills);
 
         String playerKillsLore = toolStats.getLoreFromConfig("kills.player", false);
@@ -264,16 +264,16 @@ private ItemStack updateMobKills(ItemStack itemStack) {
         if (meta == null) {
             return null;
         }
-        Integer mobKills = 0;
+        Integer mobKills = null;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.swordMobKills, PersistentDataType.INTEGER)) {
             mobKills = container.get(toolStats.swordMobKills, PersistentDataType.INTEGER);
         }
         if (mobKills == null) {
-            return null;
-        } else {
-            mobKills++;
+            mobKills = 0;
         }
+
+        mobKills++;
         container.set(toolStats.swordMobKills, PersistentDataType.INTEGER, mobKills);
 
         String mobKillsLore = toolStats.getLoreFromConfig("kills.mob", false);
@@ -326,16 +326,16 @@ private void updateArmorDamage(ItemStack itemStack, double damage) {
         if (meta == null) {
             return;
         }
-        Double damageTaken = 0.0;
+        Double damageTaken = null;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.armorDamage, PersistentDataType.DOUBLE)) {
             damageTaken = container.get(toolStats.armorDamage, PersistentDataType.DOUBLE);
         }
         if (damageTaken == null) {
-            return;
-        } else {
-            damageTaken = damageTaken + damage;
+            damageTaken = 0.0;
         }
+
+        damageTaken = damageTaken + damage;
         container.set(toolStats.armorDamage, PersistentDataType.DOUBLE, damageTaken);
 
         String damageTakenLore = toolStats.getLoreFromConfig("damage-taken", false);

src/main/java/lol/hyper/toolstats/events/PlayerFish.java

@@ -82,16 +82,16 @@ private void updateFishCount(ItemStack itemStack) {
         if (meta == null) {
             return;
         }
-        Integer fishCaught = 0;
+        Integer fishCaught = null;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.fishingRodCaught, PersistentDataType.INTEGER)) {
             fishCaught = container.get(toolStats.fishingRodCaught, PersistentDataType.INTEGER);
         }
         if (fishCaught == null) {
-            return;
-        } else {
-            fishCaught++;
+            fishCaught = 0;
         }
+
+        fishCaught++;
         container.set(toolStats.fishingRodCaught, PersistentDataType.INTEGER, fishCaught);
 
         String fishCaughtLore = toolStats.getLoreFromConfig("fished.fish-caught", false);

src/main/java/lol/hyper/toolstats/events/SheepShear.java

@@ -84,10 +84,10 @@ private void addLore(ItemStack itemStack) {
             sheepSheared = container.get(toolStats.shearsSheared, PersistentDataType.INTEGER);
         }
         if (sheepSheared == null) {
-            return;
-        } else {
-            sheepSheared++;
+            sheepSheared = 0;
         }
+
+        sheepSheared++;
         container.set(toolStats.shearsSheared, PersistentDataType.INTEGER, sheepSheared);
 
         String sheepShearedLore = toolStats.getLoreFromConfig("sheep-sheared", false);

src/main/java/lol/hyper/toolstats/events/VillagerTrade.java

@@ -78,7 +78,6 @@ public void onTrade(InventoryClickEvent event) {
                     if (newItem != null) {
                         // this gets delayed since villager inventories suck for no reason
                         Bukkit.getScheduler().runTaskLater(toolStats, () -> event.setCurrentItem(newItem), 5);
-                        return;
                     }
                 }
             }