fix deepsource problems

Author: hyperdefined

src/main/java/lol/hyper/toolstats/ToolStats.java

@@ -186,7 +186,7 @@ public boolean checkConfig(ItemStack itemStack, String configName) {
                 itemType = "trident";
             }
         } else {
-            itemType = itemName.substring(itemName.indexOf("_") + 1);
+            itemType = itemName.substring(itemName.indexOf('_') + 1);
         }
 
         if (itemType == null) {

src/main/java/lol/hyper/toolstats/events/BlocksMined.java

@@ -74,12 +74,10 @@ private void updateBlocksMined(ItemStack playerTool) {
         }
         // read the current stats from the item
         // if they don't exist, then start from 0
-        Integer blocksMined;
+        Integer blocksMined = 0;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.genericMined, PersistentDataType.INTEGER)) {
             blocksMined = container.get(toolStats.genericMined, PersistentDataType.INTEGER);
-        } else {
-            blocksMined = 0;
         }
 
         if (blocksMined == null) {

src/main/java/lol/hyper/toolstats/events/EntityDamage.java

@@ -220,13 +220,12 @@ private ItemStack updatePlayerKills(ItemStack itemStack) {
             toolStats.logger.warning(itemStack + " does NOT have any meta! Unable to update stats.");
             return null;
         }
-        Integer playerKills;
+        Integer playerKills = 0;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.swordPlayerKills, PersistentDataType.INTEGER)) {
             playerKills = container.get(toolStats.swordPlayerKills, PersistentDataType.INTEGER);
-        } else {
-            playerKills = 0;
         }
+
         if (playerKills == null) {
             playerKills = 0;
             toolStats.logger.warning(itemStack + " does not have valid player-kills set! Resting to zero. This should NEVER happen.");
@@ -287,12 +286,10 @@ private ItemStack updateMobKills(ItemStack itemStack) {
             toolStats.logger.warning(itemStack + " does NOT have any meta! Unable to update stats.");
             return null;
         }
-        Integer mobKills;
+        Integer mobKills = 0;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.swordMobKills, PersistentDataType.INTEGER)) {
             mobKills = container.get(toolStats.swordMobKills, PersistentDataType.INTEGER);
-        } else {
-            mobKills = 0;
         }
 
         if (mobKills == null) {
@@ -354,12 +351,10 @@ private void updateArmorDamage(ItemStack itemStack, double damage) {
             toolStats.logger.warning(itemStack + " does NOT have any meta! Unable to update stats.");
             return;
         }
-        Double damageTaken;
+        Double damageTaken = 0.0;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.armorDamage, PersistentDataType.DOUBLE)) {
             damageTaken = container.get(toolStats.armorDamage, PersistentDataType.DOUBLE);
-        } else {
-            damageTaken = 0.0;
         }
 
         if (damageTaken == null) {

src/main/java/lol/hyper/toolstats/events/PlayerFish.java

@@ -91,12 +91,10 @@ private void updateFishCount(ItemStack fishingRod) {
             toolStats.logger.warning(fishingRod + " does NOT have any meta! Unable to update stats.");
             return;
         }
-        Integer fishCaught;
+        Integer fishCaught = 0;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.fishingRodCaught, PersistentDataType.INTEGER)) {
             fishCaught = container.get(toolStats.fishingRodCaught, PersistentDataType.INTEGER);
-        } else {
-            fishCaught = 0;
         }
 
         if (fishCaught == null) {

src/main/java/lol/hyper/toolstats/events/SheepShear.java

@@ -86,12 +86,10 @@ private ItemStack addLore(ItemStack oldShears) {
             toolStats.logger.warning(newShears + " does NOT have any meta! Unable to update stats.");
             return null;
         }
-        Integer sheepSheared;
+        Integer sheepSheared = 0;
         PersistentDataContainer container = meta.getPersistentDataContainer();
         if (container.has(toolStats.shearsSheared, PersistentDataType.INTEGER)) {
             sheepSheared = container.get(toolStats.shearsSheared, PersistentDataType.INTEGER);
-        } else {
-            sheepSheared = 0;
         }
 
         if (sheepSheared == null) {