Skip to content

Commit 2833fae

Browse files
authored
migration: follow telemetry.distro semantic convention (logs) (#192)
https://opentelemetry.io/docs/specs/semconv/resource/#telemetry-distro
1 parent 7831007 commit 2833fae

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.changeset/wise-cows-hunt.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@hyperdx/node-opentelemetry': minor
3+
---
4+
5+
migration: follow telemetry.distro semantic convention (logs)

packages/node-opentelemetry/src/otel-logger/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ export class Logger {
103103
this.provider = new LoggerProvider({
104104
resource: detectedResource.merge(
105105
new Resource({
106-
// TODO: should use otel semantic conventions
107-
'hyperdx.distro.version': PKG_VERSION,
106+
'telemetry.distro.name': 'hyperdx',
107+
'telemetry.distro.version': PKG_VERSION,
108108
[SEMRESATTRS_SERVICE_NAME]: service ?? _serviceName,
109109
...resourceAttributes,
110110
}),

0 commit comments

Comments
 (0)