chore: add 'prettier' + 'simple-import-sort' linting rules (#169)

Only apply linting fixes

Author: wrn14897

package.json

@@ -18,7 +18,13 @@
     "prepare": "husky install"
   },
   "lint-staged": {
-    "**/*": "prettier --write --ignore-unknown"
+    "**/*.{ts,tsx}": [
+      "prettier --write --ignore-unknown",
+      "eslint --fix"
+    ],
+    "**/*.{json,yml}": [
+      "prettier --write --ignore-unknown"
+    ]
   },
   "devDependencies": {
     "@changesets/cli": "^2.26.1",
@@ -29,13 +35,15 @@
     "@typescript-eslint/eslint-plugin": "^5.59.9",
     "@typescript-eslint/parser": "^5.59.9",
     "eslint": "^8.42.0",
-    "eslint-config-prettier": "^8.8.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-jest": "^27.2.1",
+    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
     "husky": "^8.0.3",
     "jest": "^29.5.0",
     "lint-staged": "^13.2.2",
     "nx": "^15.9.2",
-    "prettier": "^2.8.7",
+    "prettier": "^3.3.3",
     "rimraf": "^5.0.1",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",

packages/browser/.eslintrc.json

@@ -10,18 +10,17 @@
     "sourceType": "module",
     "ecmaVersion": 2020
   },
-  "plugins": ["@typescript-eslint", "jest"],
+  "plugins": ["@typescript-eslint", "jest", "prettier", "simple-import-sort"],
   "extends": [
     "eslint:recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:jest/recommended",
-    "prettier"
+    "plugin:prettier/recommended"
   ],
   "rules": {
-    // The following rule is enabled only to supplement the inline suppression
-    // examples, and because it is not a recommended rule, you should either
-    // disable it, or understand what it enforces.
-    // https://typescript-eslint.io/rules/explicit-function-return-type/
-    "@typescript-eslint/explicit-function-return-type": "warn"
+    "@typescript-eslint/explicit-function-return-type": "warn",
+    "prettier/prettier": "error",
+    "simple-import-sort/exports": "error",
+    "simple-import-sort/imports": "error"
   }
 }

packages/browser/src/index.ts

@@ -1,11 +1,10 @@
+import type { RumOtelWebConfig } from '@hyperdx/otel-web';
 import Rum from '@hyperdx/otel-web';
 import SessionRecorder from '@hyperdx/otel-web-session-recorder';
 import opentelemetry, { Attributes } from '@opentelemetry/api';
 
 import { resolveAsyncGlobal } from './utils';
 
-import type { RumOtelWebConfig } from '@hyperdx/otel-web';
-
 type ErrorBoundaryComponent = any; // TODO: Define ErrorBoundary type
 
 type Instrumentations = RumOtelWebConfig['instrumentations'];

packages/instrumentation-exception/.eslintrc.json

@@ -10,20 +10,19 @@
     "sourceType": "module",
     "ecmaVersion": 2020
   },
-  "plugins": ["@typescript-eslint", "jest"],
+  "plugins": ["@typescript-eslint", "jest", "prettier", "simple-import-sort"],
   "extends": [
     "eslint:recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:jest/recommended",
-    "prettier"
+    "plugin:prettier/recommended"
   ],
   "rules": {
-    // The following rule is enabled only to supplement the inline suppression
-    // examples, and because it is not a recommended rule, you should either
-    // disable it, or understand what it enforces.
-    // https://typescript-eslint.io/rules/explicit-function-return-type/
     "@typescript-eslint/ban-ts-comment": "warn",
     "@typescript-eslint/explicit-function-return-type": "warn",
-    "@typescript-eslint/no-this-alias": "warn"
+    "@typescript-eslint/no-this-alias": "warn",
+    "prettier/prettier": "error",
+    "simple-import-sort/exports": "error",
+    "simple-import-sort/imports": "error"
   }
 }

packages/instrumentation-exception/src/browser/eventbuilder.ts

@@ -83,8 +83,8 @@ function eventFromPlainObject(
           type: isEvent(exception)
             ? exception.constructor.name
             : isUnhandledRejection
-            ? 'UnhandledRejection'
-            : 'Error',
+              ? 'UnhandledRejection'
+              : 'Error',
           value: getNonErrorObjectExceptionValue(exception, {
             isUnhandledRejection,
           }),

packages/instrumentation-exception/src/browser/helpers.ts

@@ -1,11 +1,11 @@
 import { captureException, withScope } from '@sentry/core';
 import type { Mechanism, WrappedFunction } from '@sentry/types';
 import {
-  GLOBAL_OBJ,
   addExceptionMechanism,
   addExceptionTypeValue,
   addNonEnumerableProperty,
   getOriginalFunction,
+  GLOBAL_OBJ,
   markFunctionWrapped,
 } from '@sentry/utils';
 

packages/instrumentation-exception/src/browser/index.ts

@@ -1,22 +1,22 @@
-import type { ClientOptions, Event, EventHint } from '@sentry/types';
+import { getEventProcessor } from '@hyperdx/instrumentation-sentry-node';
+import { Attributes, diag, Span, trace, Tracer } from '@opentelemetry/api';
 import {
   dedupeIntegration,
   functionToStringIntegration,
   inboundFiltersIntegration,
   prepareEvent,
 } from '@sentry/core';
-import { Attributes, Span, Tracer, diag, trace } from '@opentelemetry/api';
-import { getEventProcessor } from '@hyperdx/instrumentation-sentry-node';
+import type { ClientOptions, Event, EventHint } from '@sentry/types';
 
+import { name as PKG_NAME, version as PKG_VERSION } from '../../package.json';
+import { eventFromUnknownInput } from './eventbuilder';
 import { browserApiErrorsIntegration } from './integrations/browserapierrors';
 import { contextLinesIntegration } from './integrations/contextlines';
-import { defaultStackParser } from './stack-parsers';
-import { eventFromUnknownInput } from './eventbuilder';
 import { globalHandlersIntegration } from './integrations/globalhandlers';
 import { httpContextIntegration } from './integrations/httpcontext';
 import { hyperdxIntegration } from './integrations/hyperdx';
 import { linkedErrorsIntegration } from './integrations/linkederrors';
-import { name as PKG_NAME, version as PKG_VERSION } from '../../package.json';
+import { defaultStackParser } from './stack-parsers';
 
 // TODO: does it make sense to have a default tracer here?
 const defaultTracer = trace.getTracer(PKG_NAME, PKG_VERSION);

packages/instrumentation-exception/src/browser/instrumentations/HyperDXErrorInstrumentation.ts

@@ -1,12 +1,12 @@
-import * as shimmer from 'shimmer';
 import { Span } from '@opentelemetry/api';
 import {
   InstrumentationBase,
   InstrumentationConfig,
 } from '@opentelemetry/instrumentation';
+import * as shimmer from 'shimmer';
 
 import { recordException } from '../';
-import { limitLen, getElementXPath } from './utils';
+import { getElementXPath, limitLen } from './utils';
 
 // FIXME take timestamps from events?
 
@@ -109,8 +109,8 @@ export class HyperDXErrorInstrumentation extends InstrumentationBase {
       useful(err.name)
         ? err.name
         : err.constructor && err.constructor.name
-        ? err.constructor.name
-        : 'Error',
+          ? err.constructor.name
+          : 'Error',
     );
     span.setAttribute('error.message', limitLen(msg, MESSAGE_LIMIT));
     addStackIfUseful(span, err);

packages/instrumentation-exception/src/browser/integrations/contextlines.ts

@@ -1,8 +1,8 @@
 import { defineIntegration } from '@sentry/core';
 import type { Event, IntegrationFn, StackFrame } from '@sentry/types';
 import {
-  GLOBAL_OBJ,
   addContextToFrame,
+  GLOBAL_OBJ,
   stripUrlQueryAndFragment,
 } from '@sentry/utils';
 

packages/instrumentation-exception/src/browser/integrations/globalhandlers.ts

@@ -1,5 +1,5 @@
-import { captureEvent, defineIntegration, getClient } from '@sentry/core';
 import { diag } from '@opentelemetry/api';
+import { captureEvent, defineIntegration, getClient } from '@sentry/core';
 import type {
   Client,
   Event,
@@ -8,12 +8,12 @@ import type {
   StackParser,
 } from '@sentry/types';
 import {
-  UNKNOWN_FUNCTION,
   addGlobalErrorInstrumentationHandler,
   addGlobalUnhandledRejectionInstrumentationHandler,
   getLocationHref,
   isPrimitive,
   isString,
+  UNKNOWN_FUNCTION,
 } from '@sentry/utils';
 
 import { eventFromUnknownInput } from '../eventbuilder';