Remove @ts-nocheck from frontend files to ensure app is fully typechecked (#1530)

Noticed some errors during runtime testing of another PR that should have been caught by typescript. This fixes reduces the chances of that slipping through CI

Author: brandon-pereira

packages/app/src/AuthPage.tsx

@@ -1,10 +1,8 @@
-// @ts-nocheck TODO: remove this line
-
 import { useEffect } from 'react';
 import Link from 'next/link';
 import { useRouter } from 'next/router';
 import { NextSeo } from 'next-seo';
-import cx from 'classnames';
+import { HTTPError } from 'ky';
 import { SubmitHandler, useForm, useWatch } from 'react-hook-form';
 import {
   Button,
@@ -92,17 +90,18 @@ export default function AuthPage({ action }: { action: 'register' | 'login' }) {
       {
         onSuccess: () => router.push('/search'),
         onError: async error => {
-          const jsonData = await error.response.json();
+          if (error instanceof HTTPError) {
+            const jsonData = await error.response.json();
 
-          if (Array.isArray(jsonData) && jsonData[0]?.errors?.issues) {
-            return jsonData[0].errors.issues.forEach((issue: any) => {
-              setError(issue.path[0], {
-                type: issue.code,
-                message: issue.message,
+            if (Array.isArray(jsonData) && jsonData[0]?.errors?.issues) {
+              return jsonData[0].errors.issues.forEach((issue: any) => {
+                setError(issue.path[0], {
+                  type: issue.code,
+                  message: issue.message,
+                });
               });
-            });
+            }
           }
-
           setError('root', {
             type: 'manual',
             message: 'An unexpected error occurred, please try again later.',

packages/app/src/LandingHeader.tsx

@@ -1,5 +1,3 @@
-// @ts-nocheck TODO: remove this line
-
 import Link from 'next/link';
 import { Anchor, Burger, Button, Container, Group } from '@mantine/core';
 import { useDisclosure } from '@mantine/hooks';

packages/app/src/Spotlights.tsx

@@ -1,5 +1,3 @@
-// @ts-nocheck TODO: remove this line
-
 import * as React from 'react';
 import { useRouter } from 'next/router';
 import { Spotlight, SpotlightActionData } from '@mantine/spotlight';
@@ -11,7 +9,6 @@ import {
   IconGridDots,
   IconHelpCircle,
   IconLayout,
-  IconLayoutSidebar,
   IconLogs,
   IconSearch,
   IconSettings,
@@ -38,28 +35,27 @@ export const useSpotlightActions = () => {
     // Saved searches
     logViews.forEach(logView => {
       logViewActions.push({
-        id: logView._id,
+        id: logView.id,
         group: 'Saved searches',
         leftSection: <IconLogs size={16} />,
-        description: logView.query,
         label: logView.name,
         keywords: ['search', 'log', 'saved'],
         onClick: () => {
-          router.push(`/search/${logView._id}`);
+          router.push(`/search/${logView.id}`);
         },
       });
     });
 
     // Dashboards
     dashboards.forEach(dashboard => {
       logViewActions.push({
-        id: dashboard._id,
+        id: dashboard.id,
         group: 'Dashboards',
         leftSection: <IconLayout size={16} />,
         label: dashboard.name,
         keywords: ['dashboard'],
         onClick: () => {
-          router.push(`/dashboards/${dashboard._id}`);
+          router.push(`/dashboards/${dashboard.id}`);
         },
       });
     });

packages/app/src/api.ts

@@ -10,6 +10,7 @@ import type { UseQueryOptions } from '@tanstack/react-query';
 import { useMutation, useQuery } from '@tanstack/react-query';
 
 import { IS_LOCAL_MODE } from './config';
+import { Dashboard } from './dashboard';
 import type { AlertsPageItem } from './types';
 
 type ServicesResponse = {
@@ -112,14 +113,14 @@ const api = {
         }),
     });
   },
-  useDashboards(options?: UseQueryOptions<any, Error>) {
+  useDashboards(options?: UseQueryOptions<Dashboard[] | null, Error>) {
     return useQuery({
       queryKey: [`dashboards`],
       queryFn: () => {
         if (IS_LOCAL_MODE) {
           return null;
         }
-        return hdxServer(`dashboards`, { method: 'GET' }).json();
+        return hdxServer(`dashboards`, { method: 'GET' }).json<Dashboard[]>();
       },
       ...options,
     });
@@ -501,8 +502,15 @@ const api = {
   },
   useRegisterPassword() {
     return useMutation({
-      // @ts-ignore
-      mutationFn: async ({ email, password, confirmPassword }) =>
+      mutationFn: async ({
+        email,
+        password,
+        confirmPassword,
+      }: {
+        email: string;
+        password: string;
+        confirmPassword: string;
+      }) =>
         hdxServer(`register/password`, {
           method: 'POST',
           json: {