review: Address review comments and knip findings

Author: pulpdrew

packages/app/src/DBDashboardPage.tsx

@@ -1577,13 +1577,15 @@ function DBDashboardPage() {
               <Menu.Item
                 leftSection={<IconTrash size={16} />}
                 color="red"
-                onClick={() =>
-                  deleteDashboard.mutate(dashboard?.id ?? '', {
-                    onSuccess: () => {
-                      router.push('/dashboards');
-                    },
-                  })
-                }
+                onClick={() => {
+                  if (dashboard?.id) {
+                    deleteDashboard.mutate(dashboard?.id, {
+                      onSuccess: () => {
+                        router.push('/dashboards');
+                      },
+                    });
+                  }
+                }}
               >
                 Delete Dashboard
               </Menu.Item>

packages/app/src/components/Dashboards/DashboardsListPage.tsx

@@ -28,7 +28,7 @@ import {
 } from '@tabler/icons-react';
 
 import { PageHeader } from '@/components/PageHeader';
-import { IS_K8S_DASHBOARD_ENABLED, IS_LOCAL_MODE } from '@/config';
+import { IS_K8S_DASHBOARD_ENABLED } from '@/config';
 import {
   useCreateDashboard,
   useDashboards,
@@ -102,10 +102,6 @@ export default function DashboardsListPage() {
   }, [dashboards, search, tagFilter]);
 
   const handleCreate = useCallback(() => {
-    if (IS_LOCAL_MODE) {
-      Router.push('/dashboards');
-      return;
-    }
     createDashboard.mutate(
       { name: 'My Dashboard', tiles: [], tags: [] },
       {

packages/app/src/types.ts

@@ -60,8 +60,6 @@ export type SearchConfig = {
   orderBy?: string | null;
 };
 
-export type ServerDashboard = z.infer<typeof DashboardSchema>;
-
 export type Session = {
   errorCount: string;
   maxTimestamp: string;

packages/app/src/utils.ts

@@ -523,19 +523,6 @@ export function getColorFromCSSVariable(index: number): string {
   return COLORS[index % colorArrayLength];
 }
 
-export function hashCode(str: string) {
-  let hash = 0,
-    i,
-    chr;
-  if (str.length === 0) return hash;
-  for (i = 0; i < str.length; i++) {
-    chr = str.charCodeAt(i);
-    hash = (hash << 5) - hash + chr;
-    hash |= 0; // Convert to 32bit integer
-  }
-  return hash;
-}
-
 /**
  * Gets theme-aware chart color from CSS variable or falls back to palette.
  * Reads from --color-chart-{type} CSS variable, falls back to theme-appropriate palette.