Skip to content

Commit 562dd7e

Browse files
authored
Fix minor UI issues (#1382)
1 parent 59422a1 commit 562dd7e

24 files changed

+617
-307
lines changed

.changeset/fix-minor-ui-issues.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@hyperdx/app': patch
3+
---
4+
5+
Fix minor UI issues and enhance styling across various components

packages/app/.storybook/preview.tsx

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,40 @@ import '../styles/app.scss';
1616
import { meHandler } from '../src/mocks/handlers';
1717
import { ThemeWrapper } from '../src/ThemeWrapper';
1818

19+
export const parameters = {
20+
layout: 'fullscreen',
21+
options: {
22+
showPanel: false,
23+
storySort: (a, b) =>
24+
a.title.localeCompare(b.title, undefined, { numeric: true }),
25+
},
26+
};
27+
28+
export const globalTypes = {
29+
theme: {
30+
name: 'Theme',
31+
description: 'Mantine color scheme',
32+
defaultValue: 'light',
33+
toolbar: {
34+
icon: 'mirror',
35+
items: [
36+
{ value: 'light', title: 'Light' },
37+
{ value: 'dark', title: 'Dark' },
38+
],
39+
},
40+
},
41+
};
42+
1943
initialize();
2044

2145
const queryClient = new QueryClient();
2246

2347
const preview: Preview = {
2448
decorators: [
25-
Story => (
49+
(Story, context) => (
2650
<QueryClientProvider client={queryClient}>
2751
<QueryParamProvider adapter={NextAdapter}>
28-
<ThemeWrapper>
52+
<ThemeWrapper colorScheme={context.globals.theme || 'light'}>
2953
<Story />
3054
</ThemeWrapper>
3155
</QueryParamProvider>
@@ -37,6 +61,7 @@ const preview: Preview = {
3761
msw: {
3862
handlers: [meHandler],
3963
},
64+
backgrounds: { disable: true },
4065
},
4166
};
4267

packages/app/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@
111111
"@storybook/addon-interactions": "^8.1.5",
112112
"@storybook/addon-links": "^8.1.5",
113113
"@storybook/addon-styling-webpack": "^1.0.0",
114+
"@storybook/addon-themes": "^10.0.8",
114115
"@storybook/blocks": "^8.1.5",
115116
"@storybook/nextjs": "^8.1.5",
116117
"@storybook/react": "^8.1.5",

packages/app/src/AppNav.components.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ export const AppNavLink = ({
293293
const testId = `nav-link-${href.replace(/^\//, '').replace(/\//g, '-') || 'home'}`;
294294

295295
return (
296-
<Group justify="space-between" px="md" py="6px">
296+
<Group justify="space-between" px="md" py="6px" h="34px">
297297
<Link
298298
data-testid={testId}
299299
href={href}

packages/app/src/AppNav.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,7 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) {
409409
const isCollapsed = isSmallScreen || isPreferCollapsed;
410410

411411
const navWidth = isCollapsed ? 50 : 230;
412+
const navHeaderStyle = isCollapsed ? undefined : { height: 58 };
412413

413414
useEffect(() => {
414415
HyperDX.addAction('user navigated', {
@@ -604,7 +605,10 @@ export default function AppNav({ fixed = false }: { fixed?: boolean }) {
604605
}}
605606
>
606607
<div style={{ width: navWidth }}>
607-
<div className="p-3 d-flex flex-wrap justify-content-between align-items-center">
608+
<div
609+
className="p-3 d-flex flex-wrap justify-content-between align-items-center"
610+
style={navHeaderStyle}
611+
>
608612
<Link href="/search" className="text-decoration-none">
609613
{isCollapsed ? (
610614
<div style={{ marginLeft: '-0.15rem' }}>

packages/app/src/LandingHeader.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default function LandingHeader({
3030
right: 0,
3131
background: 'var(--color-bg-body)',
3232
backdropFilter: 'blur(12px)',
33-
border: '1px solid var(--color-border)',
33+
borderBottom: '1px solid var(--color-border)',
3434
zIndex: 100,
3535
}}
3636
>
@@ -47,12 +47,13 @@ export default function LandingHeader({
4747
color="white"
4848
/>
4949

50-
<Group gap="md" visibleFrom="lg" style={{ fontSize: 14 }}>
50+
<Group gap="lg" visibleFrom="lg">
5151
<Anchor
5252
href="https://hyperdx.io"
5353
c={activeKey === 'cloud' ? 'green' : 'gray'}
5454
underline="never"
5555
style={{ fontWeight: activeKey === 'cloud' ? 600 : 400 }}
56+
size="sm"
5657
>
5758
HyperDX Cloud
5859
</Anchor>
@@ -61,6 +62,7 @@ export default function LandingHeader({
6162
c={activeKey === 'docs' ? 'green' : 'gray'}
6263
underline="never"
6364
style={{ fontWeight: activeKey === 'docs' ? 600 : 400 }}
65+
size="sm"
6466
>
6567
Docs
6668
</Anchor>
@@ -70,6 +72,7 @@ export default function LandingHeader({
7072
c={activeKey === '/login' ? 'green' : 'gray'}
7173
underline="never"
7274
style={{ fontWeight: activeKey === '/login' ? 600 : 400 }}
75+
size="sm"
7376
>
7477
Login
7578
</Anchor>

0 commit comments

Comments
 (0)