Skip to content

Commit 99e7ce2

Browse files
prevent excessive trace events when DBRowTable is used (#1498)
Currently, each column was adding 1 extra event listener, so this resulted in several extra traces being created. Given that these popover buttons on rows don't need click outside logic (they auto-close) we can turn off these events to significantly reduce the listeners. Before: https://github.com/user-attachments/assets/6498e309-9e2c-42af-ba85-d9684d49e9e3 After: https://github.com/user-attachments/assets/56d9302e-0ad1-4ac3-868e-6cf47a0c8492 This is coming from upstream code: https://github.com/hyperdxio/hyperdx-js/blob/main/packages/instrumentation-exception/src/browser/integrations/browserapierrors.ts#L189 Fixes HDX-2928
1 parent 61cb942 commit 99e7ce2

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
Reduce instrumentation trace events when search results shown

packages/app/src/components/DBTable/DBRowTableFieldWithPopover.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,8 @@ export const DBRowTableFieldWithPopover = ({
149149
offset={5}
150150
opened={opened}
151151
portalProps={{ target: tableContainerRef?.current ?? undefined }}
152+
closeOnClickOutside={false}
153+
clickOutsideEvents={[]}
152154
>
153155
<Popover.Target>
154156
<span

0 commit comments

Comments
 (0)