Skip to content

Commit df29f1b

Browse files
authored
Merge branch 'main' into drew/fix-service-map-span-kind-values
2 parents 39176b1 + ca693c0 commit df29f1b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+1675
-1252
lines changed

.changeset/angry-pugs-drive.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
Improvements to Webhooks rendering (grouping, icons, etc)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/common-utils": minor
3+
---
4+
5+
Add support for visualizing histogram counts

.changeset/yellow-files-deny.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
Update some forms to work better with React 19

.gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,4 +73,7 @@ docker-compose.prod.yml
7373
.volumes
7474

7575
# NX
76-
.nx/
76+
.nx/
77+
78+
# webstorm
79+
.idea

docker/hyperdx/Dockerfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ ENTRYPOINT ["sh", "/etc/local/entry.sh"]
8282

8383
# all-in-one base ############################################################################################
8484
FROM hairyhenderson/gomplate:v4.3.3-alpine AS gomplate
85-
FROM clickhouse/clickhouse-server:${CLICKHOUSE_VERSION}-alpine AS all-in-one-base
85+
FROM clickhouse/clickhouse-server:${CLICKHOUSE_VERSION}-alpine AS all-in-one-base
8686

8787
ARG CODE_VERSION
8888
ARG USER_UID=10001
@@ -110,9 +110,8 @@ COPY --from=hyperdx ./clickhouseConfig.xml /etc/clickhouse-server/config.xml
110110
COPY --from=otel-collector ./config.yaml /etc/otelcol-contrib/config.yaml
111111
COPY --from=otel-collector ./supervisor_docker.yaml.tmpl /etc/otel/supervisor.yaml.tmpl
112112

113-
# Copy otel-collector entrypoint and log rotation scripts
113+
# Copy otel-collector entrypoint script
114114
COPY --from=otel-collector --chmod=755 ./entrypoint.sh /otel-entrypoint.sh
115-
COPY --from=otel-collector --chmod=755 ./log-rotator.sh /log-rotator.sh
116115

117116
# Copy gomplate binary from the gomplate image
118117
COPY --from=gomplate /bin/gomplate /usr/local/bin/gomplate

docker/otel-collector/log-tailer.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#!/bin/sh
22
# Generic log tailer script that follows a log file and echoes new lines to stdout
3-
# Handles file rotation and truncation (e.g., when used with log-rotator.sh)
43
# Usage: log-tailer.sh <log_file_path> [sleep_interval]
54

65
# Parse arguments

packages/app/eslint.config.mjs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import prettierConfig from 'eslint-config-prettier';
88
import simpleImportSort from 'eslint-plugin-simple-import-sort';
99
import prettierPlugin from 'eslint-plugin-prettier/recommended';
1010
import playwrightPlugin from 'eslint-plugin-playwright';
11+
import reactHookFormPlugin from 'eslint-plugin-react-hook-form';
12+
import { fixupPluginRules } from '@eslint/compat';
1113

1214
export default [
1315
js.configs.recommended,
@@ -39,6 +41,7 @@ export default [
3941
react: reactPlugin,
4042
'react-hooks': reactHooksPlugin,
4143
'simple-import-sort': simpleImportSort,
44+
'react-hook-form': fixupPluginRules(reactHookFormPlugin), // not compatible with eslint 9 yet
4245
},
4346
rules: {
4447
...nextPlugin.configs.recommended.rules,
@@ -81,6 +84,7 @@ export default [
8184
],
8285
'react-hooks/exhaustive-deps': 'error',
8386
'no-console': ['error', { allow: ['warn', 'error'] }],
87+
'react-hook-form/no-use-watch': 'error',
8488
},
8589
languageOptions: {
8690
parser: tseslint.parser,

packages/app/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@
104104
},
105105
"devDependencies": {
106106
"@chromatic-com/storybook": "^4.1.3",
107+
"@eslint/compat": "^2.0.0",
107108
"@hookform/devtools": "^4.3.1",
108109
"@jedmao/location": "^3.0.0",
109110
"@playwright/test": "^1.57.0",
@@ -135,6 +136,7 @@
135136
"@types/sqlstring": "^2.3.2",
136137
"eslint-config-next": "^16.0.10",
137138
"eslint-plugin-playwright": "^2.4.0",
139+
"eslint-plugin-react-hook-form": "^0.3.1",
138140
"eslint-plugin-storybook": "10.1.4",
139141
"identity-obj-proxy": "^3.0.0",
140142
"jest": "^30.2.0",

packages/app/src/AlertsPage.tsx

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ import { ErrorBoundary } from '@/components/ErrorBoundary';
3737
import { PageHeader } from '@/components/PageHeader';
3838

3939
import { isAlertSilenceExpired } from './utils/alerts';
40+
import { getWebhookChannelIcon } from './utils/webhookIcons';
4041
import api from './api';
4142
import { withAppNav } from './layout';
4243
import type { AlertsPageItem } from './types';
@@ -367,13 +368,11 @@ function AlertDetails({ alert }: { alert: AlertsPageItem }) {
367368
}, [alert]);
368369

369370
const notificationMethod = React.useMemo(() => {
370-
if (alert.channel.type === 'webhook') {
371-
return (
372-
<Group gap={2}>
373-
Notify via <IconBrandSlack size={16} /> Webhook
374-
</Group>
375-
);
376-
}
371+
return (
372+
<Group gap={5}>
373+
Notify via {getWebhookChannelIcon(alert.channel.type)} Webhook
374+
</Group>
375+
);
377376
}, [alert]);
378377

379378
const linkTitle = React.useMemo(() => {

packages/app/src/AppNav.components.tsx

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,8 @@ export const AppNavCloudBanner = () => {
4747
<div className="my-3 bg-muted rounded p-2 text-center">
4848
<span className="fs-8">Ready to deploy on ClickHouse Cloud?</span>
4949
<div className="mt-2 mb-2">
50-
<Link
51-
href="https://clickhouse.com/docs/use-cases/observability/clickstack/getting-started#deploy-with-clickhouse-cloud"
52-
passHref
53-
legacyBehavior
54-
>
55-
<Button
56-
variant="light"
57-
size="xs"
58-
component="a"
59-
className="hover-color-white"
60-
>
50+
<Link href="https://clickhouse.com/docs/use-cases/observability/clickstack/getting-started#deploy-with-clickhouse-cloud">
51+
<Button variant="light" size="xs" className="hover-color-white">
6152
Get Started for Free
6253
</Button>
6354
</Link>

0 commit comments

Comments
 (0)