Skip to content

Commit fa4188a

Browse files
committed
Revert "chore: automatic fixes from the linter (#2074)"
This reverts commit 73b746c.
1 parent d866e99 commit fa4188a

File tree

10 files changed

+12
-6
lines changed

10 files changed

+12
-6
lines changed

packages/app/src/DBChartPage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ function AIAssistant({
166166
</Group>
167167
<Collapse in={opened}>
168168
{opened && (
169+
// eslint-disable-next-line react-hooks/refs
169170
<form onSubmit={handleSubmit(onSubmit)}>
170171
<Group mb="md">
171172
<SourceSelectControlled

packages/app/src/DOMPlayer.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ export default function DOMPlayer({
264264
);
265265
}
266266

267+
// eslint-disable-next-line react-hooks/immutability
267268
updatePlayerTimeRafRef.current = requestAnimationFrame(updatePlayerTime);
268269
}, []);
269270

packages/app/src/components/DBHeatmapChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ function Heatmap({
953953
},
954954
plugins: [
955955
// legendAsTooltipPlugin()
956-
956+
// eslint-disable-next-line react-hooks/refs -- mouseInsideRef is read at event time, not during render
957957
highlightDataPlugin({
958958
proximity: 20,
959959
yFormatter: tickFormatter,

packages/app/src/components/SQLEditor/SQLEditor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export default function SQLEditor({
9898
minHeight={'100px'}
9999
extensions={[
100100
createCodeMirrorStyleTheme(),
101-
101+
// eslint-disable-next-line react-hooks/refs
102102
compartmentRef.current.of(
103103
clickhouseSql({
104104
upperCaseKeywords: true,

packages/app/src/components/SQLEditor/SQLInlineEditor.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ export default function SQLInlineEditor({
242242
// Enable line wrapping when multiline is allowed (regardless of focus)
243243
...(allowMultiline ? [EditorView.lineWrapping] : []),
244244

245+
// eslint-disable-next-line react-hooks/refs
245246
compartmentRef.current.of(
246247
clickhouseSql({
247248
upperCaseKeywords: true,

packages/app/src/hooks/useResizable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function useResizable(
5252

5353
const endResize = useCallback(() => {
5454
document.removeEventListener('mousemove', handleResize);
55-
55+
// eslint-disable-next-line react-hooks/immutability
5656
document.removeEventListener('mouseup', endResize);
5757
}, [handleResize]);
5858

packages/app/src/hooks/useStableCallback.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export const useStableCallback = <T extends (...args: any[]) => any>(
1010
});
1111

1212
return useCallback(
13-
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
13+
// eslint-disable-next-line react-hooks/use-memo, @typescript-eslint/no-unsafe-type-assertion
1414
((...args: Parameters<T>) => callbackRef.current(...args)) as T,
1515
[],
1616
);

packages/app/src/timeQuery.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,13 @@ export function useTimeQuery({
243243
liveTailTimeRange == null &&
244244
tempLiveTailTimeRange == null &&
245245
!isInputTimeQueryLive(inputTimeQuery) &&
246+
// eslint-disable-next-line react-hooks/refs
246247
inputTimeQueryDerivedTimeQueryRef.current != null
247248
) {
248249
// Use the input time query, allows users to specify relative time ranges
249250
// via url ex. /logs?tq=Last+30+minutes
250251
// return inputTimeQueryDerivedTimeQuery as [Date, Date];
251-
252+
// eslint-disable-next-line react-hooks/refs
252253
return inputTimeQueryDerivedTimeQueryRef.current;
253254
} else if (
254255
isReady &&
@@ -344,6 +345,7 @@ export function useTimeQuery({
344345
],
345346
);
346347

348+
// eslint-disable-next-line react-hooks/refs
347349
return {
348350
isReady, // Don't search until we know what we want to do
349351
isLive,

packages/app/src/useQueryParam.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export const QueryParamProvider = ({
2828

2929
const setState = useCallback(
3030
(state: Record<string, any>) => {
31+
// eslint-disable-next-line react-hooks/immutability
3132
setCache(oldCache => {
3233
const newCache = {
3334
...oldCache,

packages/app/src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ export const usePrevious = <T>(value: T): T | undefined => {
643643
useEffect(() => {
644644
ref.current = value;
645645
});
646-
646+
// eslint-disable-next-line react-hooks/refs
647647
return ref.current;
648648
};
649649

0 commit comments

Comments
 (0)