Skip to content

Small Frontend Fixes/Cleanup #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 3 commits into from
Dec 30, 2025
Merged

Small Frontend Fixes/Cleanup #1541

kodiakhq merged 3 commits into from
Dec 30, 2025
+22 −19

Conversation

@brandon-pereira
Copy link
Member

@brandon-pereira brandon-pereira commented Dec 30, 2025 •
edited
Loading

  • Fixes issue where the threshold overlay was not shown to users
Screenshot 2025-12-30 at 3 18 26 PM - Fix session page overflow for autocomplete Screenshot 2025-12-30 at 3 18 33 PM - Remove unnecessary hook on TeamPage - Remove duplicate useWatch subscription

@brandon-pereira
Small Frontend Fixes/Cleanup
6d67ad3 
- Fixes issue where the threshold overlay was not shown to users
- Fix session page overflow for autocomplete
- Remove unnecessary hook on TeamPage
- Remove duplicate useWatch subscription
@brandon-pereira brandon-pereira requested review from a team and knudtty and removed request for a team December 30, 2025 22:19
@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 94cd454

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Dec 30, 2025 10:59pm

@claude
Copy link

claude bot commented Dec 30, 2025 •
edited
Loading

Code Review

✅ No critical issues found.

Changes look good:

  • ✅ Bug fix: getAlertReferenceLines refactor correctly handles exclusive rendering (only one overlay shows at a time)
  • ✅ Bug fix: Removed duplicate useWatch for thresholdType in DBSearchPageAlertModal.tsx:112 (was shadowing line 107)
  • ✅ Cleanup: Removed unnecessary useWatch in TeamPage.tsx:458 (redundant with SelectControlled controlled value)
  • ✅ UI fix: Removed overflow hidden that was clipping autocomplete in SessionsPage.tsx:424

All changes follow React Hook Form best practices and maintain existing functionality.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025 •
edited
Loading

E2E Test Results

✅ All tests passed • 55 passed • 4 skipped • 702s

Status Count
✅ Passed 55
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq kodiakhq bot merged commit 2c288b1 into main Dec 30, 2025
12 checks passed
@kodiakhq kodiakhq bot deleted the brandon/several-bug-fixes branch December 30, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhable dhable dhable approved these changes

@knudtty knudtty Awaiting requested review from knudtty knudtty was automatically assigned from hyperdxio/hyperdx-team

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandon-pereira @dhable