Skip to content

Commit d1acea2

Browse files
committed
Optimized code to avoid copy memory.
1 parent 22ee8f3 commit d1acea2

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

server/json_rpc_handler.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ func NewTcpServerHandler(callback JsonRPCHandler) Handler {
1313
return func(conn net.Conn, packet *roc.Packet, server *TcpServer) {
1414
route := &formatter.JsonRPCRoute{}
1515
body := packet.GetBody()
16-
serializer := server.Serializer
17-
packer := server.Packer
1816

19-
err := serializer.UnSerialize(body, route)
17+
err := server.Serializer.UnSerialize(body, route)
2018
var response any
2119

2220
if err != nil {
@@ -48,7 +46,7 @@ func NewTcpServerHandler(callback JsonRPCHandler) Handler {
4846
}
4947
}
5048

51-
serialized, err := serializer.Serialize(response)
49+
serialized, err := server.Serializer.Serialize(response)
5250
if err != nil {
5351
response = &formatter.JsonRPCErrorResponse[any]{
5452
Id: route.Id,
@@ -58,14 +56,14 @@ func NewTcpServerHandler(callback JsonRPCHandler) Handler {
5856
Context: nil,
5957
}
6058

61-
serialized, err = serializer.Serialize(response)
59+
serialized, err = server.Serializer.Serialize(response)
6260
if err != nil {
6361
conn.Close()
6462
return
6563
}
6664
}
6765

68-
bt := packer.Pack(roc.NewPacket(packet.GetId(), serialized))
66+
bt := server.Packer.Pack(roc.NewPacket(packet.GetId(), serialized))
6967

7068
conn.Write(bt)
7169
}

server/tcp_server.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ func (s *TcpServer) handle(conn net.Conn) {
9292
return
9393
}
9494

95-
packer := &roc.Packer{}
96-
packet := packer.UnPack(buf)
95+
packet := s.Packer.UnPack(buf)
9796
if packet.IsHeartbeat() {
9897
go s.sendHeartbeat(conn, packet)
9998
continue

0 commit comments

Comments
 (0)