Fixed bug that validateJson was incompatibility with php 8.0 (#6146)

* Fixed bug that `validateJson` cannot work when using php 8.0.
* Fixed unit cases for redis cannot work.

Co-authored-by: 李铭昕 <[email protected]>
Co-authored-by: Deeka Wong <[email protected]>

Author: 3 people

src/Concerns/ValidatesAttributes.php

@@ -27,6 +27,7 @@
 use Hyperf\Validation\ValidationData;
 use InvalidArgumentException;
 use SplFileInfo;
+use Stringable;
 use Throwable;
 
 use function Hyperf\Collection\last;
@@ -743,13 +744,17 @@ public function validateIpv6(string $attribute, $value): bool
      */
     public function validateJson(string $attribute, $value): bool
     {
-        if (! is_scalar($value) && ! method_exists($value, '__toString')) {
-            return false;
+        if ($value instanceof Stringable) {
+            $value = (string) $value;
         }
 
-        json_decode($value);
+        try {
+            json_decode($value, flags: JSON_THROW_ON_ERROR);
+        } catch (Throwable) {
+            return false;
+        }
 
-        return json_last_error() === JSON_ERROR_NONE;
+        return true;
     }
 
     /**

tests/Cases/ValidateAttributesTest.php

@@ -13,6 +13,7 @@
 
 use HyperfTest\Validation\Cases\Stub\ValidatesAttributesStub;
 use PHPUnit\Framework\TestCase;
+use Stringable;
 
 /**
  * @internal
@@ -68,4 +69,41 @@ public function testValidateDate()
 
         $this->assertFalse($validator->validateDate('', 123));
     }
+
+    public function testValidateJson()
+    {
+        $validator = new ValidatesAttributesStub();
+        // null
+        $this->assertFalse($validator->validateJson('', null));
+        $this->assertTrue($validator->validateJson('', 'null'));
+        // int
+        $this->assertTrue($validator->validateJson('', '3'));
+        $this->assertFalse($validator->validateJson('', 3));
+        // float
+        $this->assertTrue($validator->validateJson('', '3.14'));
+        $this->assertFalse($validator->validateJson('', 3.14));
+        // string
+        $this->assertFalse($validator->validateJson('', 'plain_text'));
+        $this->assertTrue($validator->validateJson('', '{"foo": "bar"}'));
+        $this->assertFalse($validator->validateJson('', '{"foo": "bar",a}'));
+        // array
+        $this->assertTrue($validator->validateJson('', '[3.14]'));
+        $this->assertFalse($validator->validateJson('', [3.14]));
+        $this->assertTrue($validator->validateJson('', '["a"]'));
+        // object
+        $this->assertFalse($validator->validateJson('', new class() {}));
+        $this->assertTrue($validator->validateJson('', new class() implements Stringable {
+            public function __toString(): string
+            {
+                return json_encode(['foo' => 'bar'], JSON_UNESCAPED_UNICODE);
+            }
+        }));
+
+        $this->assertTrue($validator->validateJson('', new class() {
+            public function __toString(): string
+            {
+                return json_encode(['foo' => 'bar'], JSON_UNESCAPED_UNICODE);
+            }
+        }));
+    }
 }