Minor Cleanups

Author: Lord-Grey

include/hyperion/PriorityMuxer.h

@@ -7,7 +7,6 @@
 // QT includes
 #include <QMap>
 #include <QObject>
-#include <QMap>
 #include <QVector>
 
 // Utils includes
@@ -16,8 +15,8 @@
 #include <utils/Components.h>
 
 // global defines
-#define SMOOTHING_MODE_DEFAULT 0
-#define SMOOTHING_MODE_PAUSE   1
+constexpr auto SMOOTHING_MODE_DEFAULT = 0;
+constexpr auto SMOOTHING_MODE_PAUSE = 1;
 
 class QTimer;
 class Logger;

include/leddevice/LedDeviceWrapper.h

@@ -6,7 +6,6 @@
 #include <utils/ColorRgb.h>
 #include <utils/Components.h>
 
-#include <QMutex>
 #include <QScopedPointer>
 
 class LedDevice;

include/mdns/MdnsBrowser.h

@@ -17,11 +17,11 @@
 #include <QByteArray>
 #include <QMap>
 #include <QJsonArray>
+#include <QSharedPointer>
 #include <QScopedPointer>
 
 // Utility includes
 #include <utils/Logger.h>
-#include <utils/WeakConnect.h>
 
 namespace {
 	constexpr std::chrono::milliseconds DEFAULT_DISCOVER_TIMEOUT{ 500 };

libsrc/api/JsonInfo.cpp

@@ -4,7 +4,6 @@
 #include <api/API.h>
 
 #include <utils/ColorSys.h>
-#include <hyperion/GrabberWrapper.h>
 #include <leddevice/LedDeviceWrapper.h>
 #include <utils/SysInfo.h>
 #include <hyperion/AuthManager.h>
@@ -21,7 +20,6 @@
 #include <effectengine/EffectFileHandler.h>
 #endif
 
-
 QJsonObject JsonInfo::getInfo(const Hyperion* hyperion, Logger* log)
 {
 	QJsonObject info {};
@@ -429,7 +427,7 @@ QJsonArray JsonInfo::getComponents(const Hyperion* hyperion)
 		components = componentRegister.getRegister();
 	}
 
-	for (auto comp : components)
+	for (const auto& comp : components)
 	{
 		QJsonObject item;
 		item["name"] = QString::fromStdString(hyperion::componentToIdString(comp.first));
@@ -622,7 +620,7 @@ QJsonObject JsonInfo::discoverSources(const QString& sourceType, const QJsonObje
 template<typename GrabberType>
 void JsonInfo::discoverGrabber(QJsonArray& inputs, const QJsonObject& params) const
 {
-	GrabberType grabber;
+	GrabberType grabber{};
 	QJsonValue discoveryResult = grabber.discover(params);
 
 	if (discoveryResult.isArray())

libsrc/leddevice/LedDeviceWrapper.cpp

@@ -27,6 +27,7 @@ LedDeviceWrapper::LedDeviceWrapper(Hyperion* hyperion)
 	, _hyperion(hyperion)
 	, _ledDevice(nullptr)
 	, _isEnabled(false)
+	, _isOn(false)
 {
 	QString const subComponent = parent()->property("instance").toString();
 	_log = Logger::getInstance("LEDDEVICE", subComponent);