editorial changes

Author: Lord-Grey

include/grabber/drm/DRMFrameGrabber.h

@@ -75,13 +75,6 @@ class DRMFrameGrabber : public Grabber
 	 */
 	~DRMFrameGrabber() override;
 
-	/**
-	 * @brief Releases all allocated DRM resources.
-	 * This includes closing the device file descriptor and freeing memory associated with
-	 * connectors, encoders, CRTCs, planes, and framebuffers.
-	 */
-	void freeResources();
-
 	/**
 	 * @brief Captures a single frame from the configured DRM device.
 	 * The captured frame is processed (cropped and scaled) and stored in the provided image object.
@@ -152,6 +145,13 @@ class DRMFrameGrabber : public Grabber
 
 private:
 
+	/**
+	 * @brief Releases all allocated DRM resources.
+	 * This includes closing the device file descriptor and freeing memory associated with
+	 * connectors, encoders, CRTCs, planes, and framebuffers.
+	 */
+	void freeResources();
+
 	/**
 	 * @brief Opens the DRM device file descriptor.
 	 * @return True on success, false on failure.

libsrc/grabber/drm/DRMFrameGrabber.cpp

@@ -810,43 +810,43 @@ void DRMFrameGrabber::enumerateConnectorsAndEncoders(const drmModeRes* resources
 
 void DRMFrameGrabber::findActiveCrtc(const drmModeRes* resources)
 {
-	for (int i = 0; i < resources->count_crtcs; i++)
-	{
-		_crtc = drmModeGetCrtc(_deviceFd, resources->crtcs[i]);
-		if (_crtc && _crtc->mode_valid)
-		{
-			return;
-		}
-		drmModeFreeCrtc(_crtc);
-		_crtc = nullptr;
+    for (int i = 0; i < resources->count_crtcs; i++)
+    {
+        _crtc = drmModeGetCrtc(_deviceFd, resources->crtcs[i]);
+        if (_crtc && _crtc->mode_valid)
+        {
+            return; // Found active CRTC, so we can exit
+        }
+        drmModeFreeCrtc(_crtc);
+        _crtc = nullptr;
     }
 }
 
 bool DRMFrameGrabber::isPrimaryPlaneForCrtc(uint32_t planeId, const drmModeObjectProperties* properties)
 {
     for (unsigned int j = 0; j < properties->count_props; ++j)
     {
-		auto prop = drmModeGetProperty(_deviceFd, properties->props[j]);
-		if (!prop) continue;
+        auto prop = drmModeGetProperty(_deviceFd, properties->props[j]);
+        if (!prop) continue;
 
-		bool isPrimary = (strcmp(prop->name, "type") == 0 && properties->prop_values[j] == DRM_PLANE_TYPE_PRIMARY);
-		drmModeFreeProperty(prop);
+        bool isPrimary = (strcmp(prop->name, "type") == 0 && properties->prop_values[j] == DRM_PLANE_TYPE_PRIMARY);
+        drmModeFreeProperty(prop);
 
-		if (isPrimary)
-		{
-			auto plane = drmModeGetPlane(_deviceFd, planeId);
-			if (plane && _crtc && plane->crtc_id == _crtc->crtc_id)
-			{
-				qCDebug(grabber_drm) << plane;
-				_planes.insert({planeId, plane});
-				return true;
-			}
-			if (plane)
-			{
-				drmModeFreePlane(plane);
-			}
-		}
-	}
+        if (isPrimary)
+        {
+            auto plane = drmModeGetPlane(_deviceFd, planeId);
+            if (plane && _crtc && plane->crtc_id == _crtc->crtc_id)
+            {
+                qCDebug(grabber_drm) << plane;
+                _planes.insert({planeId, plane});
+                return true;
+            }
+            if (plane)
+            {
+                drmModeFreePlane(plane);
+            }
+        }
+    }
     return false;
 }