Removed "-c" console option on Window

Author: Lord-Grey

CHANGELOG.md

@@ -149,6 +149,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Deprecated: `serverinfo/subscribe`
   - Use `subscribe` / `unsubscribe` subcommands instead
 - Deprecated: DirectX grabber in favour of the new DXGI DDA grabber
+- Removed "-c" console option on Windows. Hyperion can be started via terminal to get the required console output
 
 ## [2.0.16](https://github.com/hyperion-project/hyperion.ng/releases/tag/2.0.16) - 2024-01
 

src/hyperiond/console.h

@@ -1,12 +1,15 @@
 #include <Windows.h>
 
-void openConsole(bool isShowConsole)
+bool openConsole(bool isShowConsole)
 {
-	if (AttachConsole(ATTACH_PARENT_PROCESS) || (isShowConsole && AllocConsole())) {
+	if (AttachConsole(ATTACH_PARENT_PROCESS))
+	{
 		FILE* fp;
 		freopen_s(&fp, "CONOUT$", "w", stdout);
 		freopen_s(&fp, "CONOUT$", "w", stderr);
 		SetConsoleTitle(TEXT("Hyperion"));
 		SetConsoleOutputCP(CP_UTF8);
+		return true;
 	}
+	return false;
 }

src/hyperiond/main.cpp

@@ -167,8 +167,8 @@ int main(int argc, char** argv)
 	parser.process(*qApp);
 
 #ifdef WIN32
-	bool isShowConsole = parser.isSet(consoleOption);
-	openConsole(isShowConsole);
+	//Attach the output to an existing console if available
+	openConsole(false);
 #endif
 
 	if (parser.isSet(versionOption))
@@ -494,14 +494,5 @@ int main(int argc, char** argv)
 
 	Info(log, "Application ended with code %d", exitCode);
 
-#ifdef _WIN32
-	if (parser.isSet(consoleOption))
-	{
-		system("pause");
-	}
-#endif
-
-	Logger::deleteInstance();
-
 	return exitCode;
 }