HA: Apply luminance formula (#1922)

Author: Lord-Grey

CHANGELOG.md

@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Hue Bridge - Alternate certificate support
 - Linux: New DRM/KMS screen grabber with plane-based capture - not feature complete yet
 - Logging/Tracing: Introduced qlogging categories to enable dynamic tracing
+- Home Assistent: dynamically set brightness for higher dynamic range (#1922)
 
 ---
 

libsrc/leddevice/dev_net/LedDeviceHomeAssistant.cpp

@@ -401,8 +401,6 @@ bool LedDeviceHomeAssistant::powerOff()
 
 int LedDeviceHomeAssistant::write(const std::vector<ColorRgb>& ledValues)
 {
-	int retVal = 0;
-
 	QJsonObject serviceAttributes{ {ENTITY_ID, QJsonArray::fromStringList(_lightEntityIds)} };
 	ColorRgb ledValue = ledValues.at(0);
 
@@ -415,20 +413,18 @@ int LedDeviceHomeAssistant::write(const std::vector<ColorRgb>& ledValues)
 	_restApi->setPath(API_LIGHT_TURN_ON);
 	serviceAttributes.insert(RGB_COLOR, QJsonArray{ ledValue.red, ledValue.green, ledValue.blue });
 
-	int brightness = _brightness;
-
-	// Some devices cannot deal with a black color and brightness > 0
-	if (ledValue == ColorRgb::BLACK)
+	int brightness;
+	if (!_isBrightnessOverwrite)
 	{
-		brightness = 0;
+		brightness = qBound(0, qRound(0.2126 * ledValue.red + 0.7152 * ledValue.green + 0.0722 * ledValue.blue), 255);
 	}
-
-	// Add brightness attribute if applicable
-	if (brightness == 0 || _isBrightnessOverwrite)
+	else
 	{
-		serviceAttributes.insert(BRIGHTNESS, brightness);
+		brightness = _brightness;
 	}
 
+	serviceAttributes.insert(BRIGHTNESS, brightness);
+
 	if (_transitionTime > 0)
 	{
 		serviceAttributes.insert(TRANSITION, _transitionTime);
@@ -438,8 +434,8 @@ int LedDeviceHomeAssistant::write(const std::vector<ColorRgb>& ledValues)
 	if (response.error())
 	{
 		Warning(_log, "Updating lights failed with error: '%s'", QSTRING_CSTR(response.getErrorReason()));
-		retVal = -1;
+		return -1;
 	}
 
-	return retVal;
+	return 0;
 }

libsrc/leddevice/schemas/schema-homeassistant.json

@@ -53,7 +53,7 @@
       "type": "boolean",
       "format": "checkbox",
       "title": "edt_dev_spec_brightnessOverwrite_title",
-      "default": true,
+      "default": false,
       "required": true,
       "access": "advanced",
       "propertyOrder": 6