Fix icon uses all strategies instead of only the first success strategy

dennypradipta · dennypradipta · commit 13aa9c5bb8e9 · 2023-05-24T14:41:51.000+07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.2]
+
+Fixed
+
+- Fix icon uses all strategies instead of only the first success strategy
+
 ## [1.0.1]
 
 Added
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hyperjumptech/favicon-fetcher",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "A utility to fetch a website's favicon",
   "main": "dist/index.js",
   "scripts": {
diff --git a/src/get-favicon.ts b/src/get-favicon.ts
@@ -77,7 +77,10 @@ export async function getFavicon(
         return Buffer.from(ab)
       })
 
-      icon = result
+      if (result) {
+        icon = result
+        break
+      }
 
       // Else, use another strategy
       continue

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@hyperjumptech/favicon-fetcher",`
`3`		`- "version": "1.0.1",`
	`3`	`+ "version": "1.0.2",`
`4`	`4`	`"description": "A utility to fetch a website's favicon",`
`5`	`5`	`"main": "dist/index.js",`
`6`	`6`	`"scripts": {`