Skip to content

Commit bdfbf79

Browse files
authored
Update: Move hardcoded Google Analytics ID to environment variable (#165)
1 parent 5a3247a commit bdfbf79

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

.env.example

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ NEXT_PUBLIC_LANDING_POST_CHATS_WEBHOOK=
22
NEXT_PUBLIC_LANDING_GET_CHATS_WEBHOOK=
33
NEXT_PUBLIC_LANDING_GET_FOLLOWUP_WEBHOOK=
44
NEXT_PUBLIC_INFERENCEAI_POST_CHATS_WEBHOOK=
5-
NEXT_PUBLIC_INFERENCEAI_GET_CHATS_WEBHOOK=
5+
NEXT_PUBLIC_INFERENCEAI_GET_CHATS_WEBHOOK=
6+
NEXT_PUBLIC_GA_TRACKING_ID=

.github/workflows/deploy.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ env:
1212
NEXT_PUBLIC_LANDING_POST_CHATS_WEBHOOK: ${{ vars.NEXT_PUBLIC_LANDING_POST_CHATS_WEBHOOK }}
1313
NEXT_PUBLIC_LANDING_GET_CHATS_WEBHOOK: ${{ vars.NEXT_PUBLIC_LANDING_GET_CHATS_WEBHOOK }}
1414
NEXT_PUBLIC_LANDING_GET_FOLLOWUP_WEBHOOK: ${{ vars.NEXT_PUBLIC_LANDING_GET_FOLLOWUP_WEBHOOK }}
15+
NEXT_PUBLIC_GA_TRACKING_ID: ${{ vars.NEXT_PUBLIC_GA_TRACKING_ID }}
1516

1617
jobs:
1718
deploy:
@@ -35,6 +36,7 @@ jobs:
3536
NEXT_PUBLIC_LANDING_POST_CHATS_WEBHOOK: ${{ vars.NEXT_PUBLIC_LANDING_POST_CHATS_WEBHOOK }}
3637
NEXT_PUBLIC_LANDING_GET_CHATS_WEBHOOK: ${{ vars.NEXT_PUBLIC_LANDING_GET_CHATS_WEBHOOK }}
3738
NEXT_PUBLIC_LANDING_GET_FOLLOWUP_WEBHOOK: ${{ vars.NEXT_PUBLIC_LANDING_GET_FOLLOWUP_WEBHOOK }}
39+
NEXT_PUBLIC_GA_TRACKING_ID: ${{ vars.NEXT_PUBLIC_GA_TRACKING_ID }}
3840

3941
- name: Create CNAME file
4042
run: echo "hyperjump.tech" > out/CNAME

app/layout.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import type { Metadata } from "next";
22
import { GoogleAnalytics } from "@next/third-parties/google";
33

4-
import data from "@/data.json";
54
import { cn } from "@/lib/utils";
65
import { supportedLanguages } from "@/locales/.generated/types";
76
import Console from "@/app/components/console";
@@ -11,15 +10,15 @@ import { figtree, geistMono, geistSans, switzer } from "./fonts";
1110
import "./globals.css";
1211
import { DEFAULT_OPENGRAPH } from "@/lib/default-metadata";
1312

14-
const { gaId } = data;
15-
1613
export const metadata: Metadata = DEFAULT_OPENGRAPH;
1714

1815
export default function RootLayout({
1916
children
2017
}: Readonly<{
2118
children: React.ReactNode;
2219
}>) {
20+
const GA_ID = process.env.NEXT_PUBLIC_GA_TRACKING_ID;
21+
2322
return (
2423
<html lang={supportedLanguages[0]}>
2524
<head>
@@ -30,7 +29,7 @@ export default function RootLayout({
3029
name="format-detection"
3130
content="telephone=no, date=no, email=no, address=no"
3231
/>
33-
<GoogleAnalytics gaId={gaId} />
32+
{GA_ID && <GoogleAnalytics gaId={GA_ID} />}
3433
</head>
3534
<body
3635
data-scroll="false"

data.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
],
2828
"description": "Your partner in building reliable, modern software.",
2929
"github": "https://github.com/hyperjumptech",
30-
"gaId": "GTM-TMWJV372",
3130
"socials": [
3231
{
3332
"platform": "LinkedIn",

0 commit comments

Comments
 (0)