fix: Lander nonce add logs (#7260)

Co-authored-by: Danil Nemirovsky <[email protected]>

Author: ameten

rust/main/chains/hyperlane-ethereum/src/rpc_clients/fallback.rs

@@ -178,7 +178,11 @@ where
             }
         }
 
-        // we don't add a warning with all errors since an error will be logged later on
+        let errors_count = retryable_errors
+            .len()
+            .saturating_add(non_retryable_errors.len());
+        warn!(errors_count, ?retryable_errors, ?non_retryable_errors, providers=?self.inner.providers, "multicast_request, all providers failed");
+
         retryable_errors.extend(non_retryable_errors);
         Err(FallbackError::AllProvidersFailed(retryable_errors).into())
     }

rust/main/lander/src/adapter/chains/ethereum/adapter.rs

@@ -622,11 +622,12 @@ impl AdaptsChain for EthereumAdapter {
         let hash = match send_result {
             Ok(hash) => hash,
             Err(e) => {
+                warn!(?e, "submitting transaction error");
                 return if e.to_string().contains(NONCE_TOO_LOW_ERROR) {
                     Err(TxAlreadyExists)
                 } else {
                     Err(e.into())
-                }
+                };
             }
         };
 

rust/main/lander/src/adapter/chains/ethereum/nonce/state/assign.rs

@@ -1,4 +1,4 @@
-use tracing::{debug, warn};
+use tracing::{debug, instrument, warn};
 
 use hyperlane_core::U256;
 
@@ -9,6 +9,7 @@ use super::super::status::NonceStatus;
 use super::NonceManagerState;
 
 impl NonceManagerState {
+    #[instrument(skip(self), fields(?tx_uuid, ?old_nonce))]
     pub(crate) async fn assign_next_nonce(
         &self,
         tx_uuid: &TransactionUuid,
@@ -51,6 +52,7 @@ impl NonceManagerState {
         Ok(next_nonce)
     }
 
+    #[instrument(skip(self), fields(?finalized_nonce, ?upper_nonce))]
     async fn identify_next_nonce(
         &self,
         finalized_nonce: Option<U256>,
@@ -72,7 +74,10 @@ impl NonceManagerState {
 
             if tracked_tx_uuid == TransactionUuid::default() {
                 // If the nonce is not tracked, we can use it.
-                debug!("There is no tracked transaction for nonce, reusing it");
+                debug!(
+                    ?next_nonce,
+                    "There is no tracked transaction for nonce, reusing it"
+                );
                 break;
             }
 

rust/main/lander/src/adapter/chains/ethereum/precursor.rs

@@ -19,7 +19,9 @@ pub struct EthereumTxPrecursor {
 impl Debug for EthereumTxPrecursor {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let gas_price = self.extract_gas_price();
+        let tx_type = self.extract_transaction_type();
         f.debug_struct("EthereumTxPrecursor")
+            .field("tx.type", &tx_type)
             .field("tx.from", &self.tx.from())
             .field("tx.to", &self.tx.to())
             .field("tx.nonce", &self.tx.nonce())
@@ -90,4 +92,12 @@ impl EthereumTxPrecursor {
             },
         }
     }
+
+    pub fn extract_transaction_type(&self) -> String {
+        match &self.tx {
+            Legacy(_) => "legacy".to_string(),
+            Eip2930(_) => "eip2930".to_string(),
+            Eip1559(_) => "eip1559".to_string(),
+        }
+    }
 }