Skip to content

Commit c68722d

Browse files
authored
fix: Add catch when calling fetchPackageVersion() (#7315)
1 parent 5c4cef1 commit c68722d

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.changeset/shiny-gifts-double.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperlane-xyz/sdk": minor
3+
---
4+
5+
Update fetchPackageVersion() to return 0.0.0 when unknown error is thrown. This error is logged out and is no longer rethrown.

typescript/sdk/src/token/EvmERC20WarpRouteReader.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ export class EvmERC20WarpRouteReader extends EvmRouterReader {
256256
);
257257

258258
const [packageVersion, tokenFee] = await Promise.all([
259-
this.fetchPackageVersion(routerAddress).catch(() => '0.0.0'),
259+
this.fetchPackageVersion(routerAddress),
260260
TokenRouter.feeRecipient().catch(() => constants.AddressZero),
261261
]);
262262

@@ -992,13 +992,14 @@ export class EvmERC20WarpRouteReader extends EvmRouterReader {
992992
try {
993993
return await contractWithVersion.PACKAGE_VERSION();
994994
} catch (err: any) {
995-
if (err.cause.code && err.cause.code === 'CALL_EXCEPTION') {
995+
if (err.cause?.code && err.cause?.code === 'CALL_EXCEPTION') {
996996
// PACKAGE_VERSION was introduced in @hyperlane-xyz/[email protected]
997997
// See https://github.com/hyperlane-xyz/hyperlane-monorepo/releases/tag/%40hyperlane-xyz%2Fcore%405.4.0
998998
// The real version of a contract without this function is below 5.4.0
999999
return '5.3.9';
10001000
} else {
1001-
throw err;
1001+
this.logger.error(`Error when fetching package version ${err}`);
1002+
return '0.0.0';
10021003
}
10031004
}
10041005
}

0 commit comments

Comments
 (0)