Skip to content

Commit dde643f

Browse files
committed
fix(satp-hermes): return missing promise in rollback strategies
Signed-off-by: atharrva01 <atharvaborade568@gmail.com>
1 parent 8a940fd commit dde643f

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

packages/cactus-plugin-satp-hermes/src/main/typescript/core/crash-management/rollback/stage0-rollback-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class Stage0RollbackStrategy implements RollbackStrategy {
9898
): Promise<void> {
9999
const fnTag = "Stage0RollbackStrategy#handleClientSideRollback";
100100
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
101-
context.with(ctx, async () => {
101+
return context.with(ctx, async () => {
102102
try {
103103
try {
104104
const networkId = {

packages/cactus-plugin-satp-hermes/src/main/typescript/core/crash-management/rollback/stage1-rollback-strategy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export class Stage1RollbackStrategy implements RollbackStrategy {
8383
): Promise<void> {
8484
const fnTag = "Stage1RollbackStrategy#handleClientSideRollback";
8585
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
86-
context.with(ctx, () => {
86+
return context.with(ctx, () => {
8787
try {
8888
try {
8989
rollbackState.rollbackLogEntries.push(
@@ -125,7 +125,7 @@ export class Stage1RollbackStrategy implements RollbackStrategy {
125125
): Promise<void> {
126126
const fnTag = "Stage1RollbackStrategy#handleServerSideRollback";
127127
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
128-
context.with(ctx, () => {
128+
return context.with(ctx, () => {
129129
try {
130130
try {
131131
rollbackState.rollbackLogEntries.push(

packages/cactus-plugin-satp-hermes/src/main/typescript/core/crash-management/rollback/stage2-rollback-strategy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export class Stage2RollbackStrategy implements RollbackStrategy {
9797
): Promise<void> {
9898
const fnTag = "Stage2RollbackStrategy#handleClientSideRollback";
9999
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
100-
context.with(ctx, async () => {
100+
return context.with(ctx, async () => {
101101
try {
102102
try {
103103
const networkId = {
@@ -166,7 +166,7 @@ export class Stage2RollbackStrategy implements RollbackStrategy {
166166
): Promise<void> {
167167
const fnTag = "Stage2RollbackStrategy#handleServerSideRollback";
168168
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
169-
context.with(ctx, () => {
169+
return context.with(ctx, () => {
170170
try {
171171
try {
172172
const network = serverSessionData.recipientGatewayNetworkId;

packages/cactus-plugin-satp-hermes/src/main/typescript/core/crash-management/rollback/stage3-rollback-strategy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export class Stage3RollbackStrategy implements RollbackStrategy {
9797
): Promise<void> {
9898
const fnTag = "Stage3RollbackStrategy#handleClientSideRollback";
9999
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
100-
context.with(ctx, async () => {
100+
return context.with(ctx, async () => {
101101
try {
102102
try {
103103
const networkId = {
@@ -172,7 +172,7 @@ export class Stage3RollbackStrategy implements RollbackStrategy {
172172
): Promise<void> {
173173
const fnTag = "Stage3RollbackStrategy#handleServerSideRollback";
174174
const { span, context: ctx } = this.monitorService.startSpan(fnTag);
175-
context.with(ctx, async () => {
175+
return context.with(ctx, async () => {
176176
try {
177177
try {
178178
const networkId = {

0 commit comments

Comments
 (0)