Release 0.3.4 London (#1811)

Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: Sean Young <[email protected]>
Co-authored-by: Sean Young <[email protected]>

Author: salaheldinsoliman

.gitignore

@@ -1,4 +1,5 @@
 /docs/build
+/docs/.venv
 Cargo.lock
 /target
 **/*.rs.bk

CHANGELOG.md

@@ -4,15 +4,49 @@ will be documented here.
 
 ## Unreleased
 
+## v0.3.4 London
+
 ### Added
+- **Soroban** Support for [Stellar Asset Contract(SAC)](https://developers.stellar.org/docs/tokens/stellar-asset-contract)
+- **Soroban** Support for [Cross Contract Calls](https://developers.stellar.org/docs/build/smart-contracts/example-contracts/cross-contract-call)
+- **Soroban** Support for [Soroban Authorization Framework](https://developers.stellar.org/docs/learn/fundamentals/contract-development/authorization)
+- **Soroban** Support for different [Soroban Storage types](https://developers.stellar.org/docs/build/guides/storage/choosing-the-right-storage)
 - **Soroban** Work on adding support for [Stellar's Soroban](https://soroban.stellar.org/docs) contracts platforms started, by adding a skeleton that supports the Soroban runtime. [Salaheldin Soliman](https://github.com/salaheldinsoliman)
-
 - The `string.concat()` and `bytes.concat()` builtin functions are supported. [seanyoung](https://github.com/seanyoung)
+- **Experimental**: Three address code format IR for the CFG has been implemented (disabled by default).
+  [fanyi-zhao](https://github.com/fanyi-zhao).
+- **Polkadot**: Compatibility with ink! v5.0 metadata and substrate-contracts-node v0.39.0
+- Implement event selectors [seanyoung](https://github.com/seanyoung)
+- Add a feature flag for compiling language server [xermicus](https://github.com/xermicus)
+- Parsing the pragma solidity version numbers, making this information available in the downstream 
+  compilation pipeline [seanyoung](https://github.com/seanyoung)
 
 ### Changed
+- **Polkadot/BREAKING**: Event encoding and topics follow [ink! v5.0](https://use.ink/faq/migrating-from-ink-4-to-5#events-20-1)
 - **BREAKING** The non-standard extension of concatenating strings using the `+` operator
   has been removed, use `string.concat()` instead. [seanyoung](https://github.com/seanyoung)
 - Removed the `--no-log-api-return-codes` compile flag as this is now done by the runtime [xermicus](https://github.com/xermicus)
+- **Solana/BREAKING**: Remove balance, transfer, and send builtins from Solana [LucasSte](https://github.com/LucasSte)
+- No longer support numbers in octal notation [seanyoung](https://github.com/seanyoung)
+- Moved to LLVM version 16 [seanyoung](https://github.com/seanyoung)
+- Improve overloaded function call diagnostics: From Solidity 0.6 onwards, overloaded functions or events
+  resolving to multiple candidates are an error. In earlier versions, the first result is used.
+  [seanyoung](https://github.com/seanyoung)
+- **Polkadot**: Implement the caller_is_root runtime API as a builtin [xermicus](https://github.com/xermicus)
+
+### Fixed
+- [Two Infinite loops in codegen](https://github.com/hyperledger-solang/solang/commit/c6db2acc8a3927fae17c437eeeea0d0ae49a67df), thanks to @smoelius.
+- [Handle abi.encode() with infinite empty arguments](https://github.com/hyperledger-solang/solang/commit/12a6d83b91f7f5a4cc48156e1112638e733e143a), thanks to @smoelius.
+- Unreachable code, function types with parameter/return names and unknown assembly flags are warnings
+  instead of errors, matching with solc. [xermicus](https://github.com/xermicus)
+- Fixed a bunch of typos in the documentation [divdeploy](https://github.com/divdeploy)
+- Clean up the LLD linker context after linking each contract, preventing potential issues when compiling
+  multiple contracts at once. [xermicus](https://github.com/xermicus)
+- Expression statement should be followed by a semicolon, fixing a bug where "_;" was incorrectly parsed
+  as a variable. [seanyoung](https://github.com/seanyoung)
+- Represent type(T) correctly in the AST, fixing various related issues [seanyoung](https://github.com/seanyoung)
+- Fix a bug in abi.encodeCall() argument parsing when there is only a single argument [seanyoung](https://github.com/seanyoung)
+- Fixed a codegen bug when the RHS of a shift expression is a struct member [PaddyClark0](https://github.com/PaddyClark0)
 
 ## v0.3.3 Atlantis
 

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "solang"
-version = "0.3.3"
+version = "0.3.4"
 authors = ["Sean Young <[email protected]>", "Lucas Steuernagel <[email protected]>", "Cyrill Leutwiler <[email protected]>"]
 repository = "https://github.com/hyperledger-solang/solang"
 documentation = "https://solang.readthedocs.io/"
@@ -10,7 +10,7 @@ description = "Solang Solidity Compiler"
 keywords = [ "solidity", "compiler", "solana", "polkadot", "substrate" ]
 rust-version = "1.85.0"
 edition = "2021"
-exclude = [ "/.*", "/docs",  "/examples", "/solana-library", "/tests", "/integration", "/vscode", "/testdata" ]
+exclude = [ "/.*", "/docs", "/solana-library", "/tests", "/integration", "/vscode", "/testdata" ]
 
 [build-dependencies]
 cc = "1.0"
@@ -46,7 +46,7 @@ itertools = ">=0.10, <=0.13"
 num-rational = "0.4"
 indexmap = "2.2"
 once_cell = "1.19"
-solang-parser = { path = "solang-parser", version = "0.3.3" }
+solang-parser = { path = "solang-parser", version = "0.3.5" }
 codespan-reporting = "0.11"
 phf = { version = "0.11", features = ["macros"] }
 rust-lapper = { version = "1.1", optional = true }
@@ -67,7 +67,7 @@ primitive-types = { version = "0.12", features = ["codec"] }
 normalize-path = "0.2.1"
 bitflags = "2.4"
 scopeguard = "1.2.0"
-forge-fmt = { path = "fmt", optional = true }
+solang-forge-fmt = { version = "0.2.0", optional = true }
 # We don't use ethers-core directly, but need the correct version for the
 # build to work.
 ethers-core = { version = "2.0.10", optional = true }
@@ -93,6 +93,7 @@ ink_primitives = "5.0.0"
 wasm_host_attr = { path = "tests/wasm_host_attr" }
 num-bigint = { version = "0.4", features = ["rand", "serde"]}
 
+
 [package.metadata.docs.rs]
 no-default-features = true
 
@@ -104,7 +105,7 @@ soroban = ["soroban-sdk"]
 default = ["llvm", "wasm_opt", "language_server", "soroban"]
 llvm = ["inkwell", "libc"]
 wasm_opt = ["llvm", "wasm-opt", "contract-build"]
-language_server = ["tower-lsp", "forge-fmt", "ethers-core", "tokio", "rust-lapper"]
+language_server = ["tower-lsp", "solang-forge-fmt", "ethers-core", "tokio", "rust-lapper"]
 
 [workspace]
 members = ["solang-parser", "fmt", "tests/wasm_host_attr"]

README.md

@@ -1,6 +1,6 @@
 <img src="https://raw.githubusercontent.com/hyperledger/solang/main/docs/hl_solang_horizontal-color.svg" alt="Solang Logo" width="75%"/>
 
-# solang - Solidity Compiler for Solana and Polkadot
+# solang - Solidity Compiler for Solana, Polkadot and Soroban
 
 [![Discord](https://img.shields.io/discord/905194001349627914?logo=Hyperledger&style=plastic)](https://discord.gg/hyperledger)
 [![CI](https://github.com/hyperledger-solang/solang/workflows/test/badge.svg)](https://github.com/hyperledger-solang/solang/actions)
@@ -9,7 +9,7 @@
 [![LoC](https://tokei.rs/b1/github/hyperledger/solang?category=lines)](https://github.com/hyperledger-solang/solang)
 
 Welcome to Solang, a new Solidity compiler written in rust which uses
-llvm as the compiler backend. Solang can compile Solidity for Solana and
+llvm as the compiler backend. Solang can compile Solidity for Solana, Soroban and the
 Polkadot Parachains with the `contracts` pallet.
 Solang is source compatible with Solidity 0.8,
 with some caveats due to differences in the underlying blockchain.
@@ -51,6 +51,40 @@ You will have a file called flipper.contract. You can use this directly in
 the [Contracts UI](https://contracts-ui.substrate.io/),
 as if your smart contract was written using ink!.
 
+
+## Build for Soroban
+
+Select one of the supported contracts for Soroban, available in on Solang's repository:
+
+```bash
+solang compile --target soroban examples/soroban/token.sol
+```
+
+You will have a file called `token.wasm`. Deploy it using the [`Stellar CLI`](https://developers.stellar.org/docs/tools/cli), after following the [`Stellar CLI Setup Manual`](https://developers.stellar.org/docs/build/smart-contracts/getting-started/setup):
+
+``` bash
+stellar contract deploy --source-account alice --wasm token.wasm --network testnet -- --_admin alice --_name SolangToken --_symbol SOLT --_decimals 18
+ℹ️  Skipping install because wasm already installed
+ℹ️  Using wasm hash b1c84d8b8057a62fb6d77ef55c9e7fb2e66c74136c7df32efd87a1c9d475f1b0
+ℹ️  Simulating deploy transaction…
+ℹ️  Transaction hash is fc3b1f00d2940e646d210e6e96347fd45dc8dd873009604ec67957edb6f6589d
+🔗 https://stellar.expert/explorer/testnet/tx/fc3b1f00d2940e646d210e6e96347fd45dc8dd873009604ec67957edb6f6589d
+ℹ️  Signing transaction: fc3b1f00d2940e646d210e6e96347fd45dc8dd873009604ec67957edb6f6589d
+🌎 Submitting deploy transaction…
+🔗 https://stellar.expert/explorer/testnet/contract/CDGUMUXA6IRRVMMKIVQJWLZZONDXBJ4AITHQS757PTBVAL4U54HI3KEW
+✅ Deployed!
+CDGUMUXA6IRRVMMKIVQJWLZZONDXBJ4AITHQS757PTBVAL4U54HI3KEW
+```
+
+Once deployed, copy the deployed contract ID and interact with it:
+
+``` bash
+stellar contract invoke --network testnet --id CDGUMUXA6IRRVMMKIVQJWLZZONDXBJ4AITHQS757PTBVAL4U54HI3KEW  --source-account alice -- mint --to alice --amount 120
+ℹ️  Signing transaction: e0d68ae85bfbe0fceed8bcadd6613e12b3159f27dbf7c18e35e94de2b4a11ee2
+```
+
+
+
 ## Tentative roadmap
 
 Solang has a high level of compatibility with many blockchains. We are trying to ensure the compiler stays
@@ -69,6 +103,7 @@ Here is a brief description of what we envision for the next versions.
 | Declare accounts for a Solidity function on Solana | In progress                                          |
 | Tooling for calls between ink! <> solidity         | In progress                                          |
 | Provide CLI for node interactions                  | [Done](https://github.com/hyperledger-solang/solang-aqd)    |
+| Support all [Soroban examples](https://github.com/stellar/soroban-examples) | In progress |
 
 ## License
 

docs/examples/soroban/auth.sol

@@ -0,0 +1,19 @@
+/// SPDX-License-Identifier: Apache-2.0
+
+contract auth {
+    // Only this address can call the increment function
+    address public owner = address"GDRIX624OGPQEX264NY72UKOJQUASHU3PYKL6DDPGSTWXWJSBOTR6N7W";
+
+ 
+    uint64 public instance counter = 20;
+
+    function increment() public returns (uint64) {
+
+        owner.requireAuth();
+
+        counter = counter + 1;
+
+        return counter;
+       
+    }
+}

docs/examples/soroban/deep_auth/a.sol

@@ -0,0 +1,14 @@
+/// SPDX-License-Identifier: Apache-2.0
+
+contract a {
+    function call_b (address b, address c) public returns (uint64) {
+        address addr = address(this);
+        // authorize contract c to be called, with function name "get_num" and "a" as an arg.
+        // get_num calls a.require_auth()
+        auth.authAsCurrContract(c, "get_num", addr);
+        bytes payload = abi.encode("increment", addr, c);
+        (bool suc, bytes returndata) = b.call(payload);
+        uint64 result = abi.decode(returndata, (uint64));
+        return result;
+    }
+}

docs/examples/soroban/deep_auth/b.sol

@@ -0,0 +1,19 @@
+/// SPDX-License-Identifier: Apache-2.0
+
+contract b {
+ 
+    uint64 public instance counter = 20;
+
+    function increment(address a, address c) public returns (uint64) {
+
+        a.requireAuth();
+        bytes payload = abi.encode("get_num", a);
+        (bool suc, bytes returndata) = c.call(payload);
+        uint64 result = abi.decode(returndata, (uint64));
+
+        counter = counter + 2;
+
+        return counter;
+       
+    }
+} 

docs/examples/soroban/deep_auth/c.sol

@@ -0,0 +1,8 @@
+/// SPDX-License-Identifier: Apache-2.0
+
+contract c {
+    function get_num(address a) public returns (uint64) {
+        a.requireAuth();
+        return 2;
+    }
+}

docs/examples/soroban/error.sol

@@ -0,0 +1,11 @@
+/// SPDX-License-Identifier: Apache-2.0
+
+contract error {
+    uint64 public count = 1;
+
+    function decrement() public returns (uint64) {
+        print("Second call will FAIL!");
+        count -= 1;
+        return count;
+    }
+}

docs/examples/soroban/storage_types.sol

@@ -0,0 +1,23 @@
+/// SPDX-License-Identifier: Apache-2.0
+
+contract storage_types {
+            
+    uint64 public temporary var = 1;
+    uint64 public instance var1 = 1;
+    uint64 public persistent var2 = 2;
+    uint64 public var3 = 2;
+
+    function inc() public {
+        var++;
+        var1++;
+        var2++;
+        var3++;
+    }
+
+    function dec() public {
+        var--;
+        var1--;
+        var2--;
+        var3--;
+    }
+}