Skip to content

Commit 8baf031

Browse files
committed
[FABCJ-214] - Java chaincode gRPC server
clean env in ChaincodeSupportClientTest, remove "stupid" debug Signed-off-by: Oleksandr Yamkovyi <[email protected]>
1 parent 8844a4f commit 8baf031

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

fabric-chaincode-shim/src/test/java/org/hyperledger/fabric/contract/ContractRouterTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ public void testCreateFailsWithoutValidOptions() {
4141
thrown.expectMessage(containsString(
4242
"The chaincode id must be specified using either the -i or --i command line options or the CORE_CHAINCODE_ID_NAME environment variable."));
4343

44-
System.out.println("CORE_CHAINCODE_NAME = " + System.getenv("CORE_CHAINCODE_ID_NAME"));
45-
4644
@SuppressWarnings("unused")
4745
final ContractRouter r = new ContractRouter(new String[] {});
4846
}

fabric-chaincode-shim/src/test/java/org/hyperledger/fabric/shim/ChaincodeBaseTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,6 @@ public void testUnsetOptionClientCertPath() {
193193
environmentVariables.set("CORE_CHAINCODE_ID_NAME", "mycc");
194194
environmentVariables.set("CORE_PEER_TLS_ENABLED", "true");
195195
cb.processEnvironmentOptions();
196-
197-
System.out.println("CORE_TLS_CLIENT_CERT_PATH = " + System.getenv("CORE_TLS_CLIENT_CERT_PATH"));
198-
199196
thrown.expect(IllegalArgumentException.class);
200197
thrown.expectMessage(Matchers.containsString("Client key certificate chain"));
201198
cb.validateOptions();
@@ -208,9 +205,6 @@ public void testUnsetOptionClientKeyPath() {
208205
environmentVariables.set("CORE_PEER_TLS_ENABLED", "true");
209206
environmentVariables.set("CORE_TLS_CLIENT_CERT_PATH", "non_exist_path3");
210207
cb.processEnvironmentOptions();
211-
212-
System.out.println("CORE_TLS_CLIENT_KEY_PATH = " + System.getenv("CORE_TLS_CLIENT_KEY_PATH"));
213-
214208
thrown.expect(IllegalArgumentException.class);
215209
thrown.expectMessage(Matchers.containsString("Client key ("));
216210
cb.validateOptions();
@@ -273,9 +267,6 @@ public void testStartFailsWithoutValidOptions() {
273267
ArgumentCaptor<LogRecord> argumentCaptor = ArgumentCaptor.forClass(LogRecord.class);
274268
Logger logger = Logger.getLogger("org.hyperledger.fabric.shim.ChaincodeBase");
275269
logger.addHandler(mockHandler);
276-
277-
System.out.println("CORE_CHAINCODE_NAME = " + System.getenv("CORE_CHAINCODE_ID_NAME"));
278-
279270
cb.start(args);
280271

281272
Mockito.verify(mockHandler, Mockito.atLeast(1)).publish(argumentCaptor.capture());

fabric-chaincode-shim/src/test/java/org/hyperledger/fabric/shim/impl/ChaincodeSupportClientTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import org.hyperledger.fabric.protos.peer.ChaincodeShim;
1313
import org.hyperledger.fabric.shim.ChaincodeBase;
1414
import org.hyperledger.fabric.shim.chaincode.EmptyChaincode;
15+
import org.junit.After;
1516
import org.junit.Rule;
1617
import org.junit.contrib.java.lang.system.EnvironmentVariables;
1718
import org.junit.jupiter.api.Assertions;
@@ -24,6 +25,11 @@ class ChaincodeSupportClientTest {
2425
@Rule
2526
public final EnvironmentVariables environmentVariables = new EnvironmentVariables();
2627

28+
@After
29+
public void cleanEnv() {
30+
environmentVariables.clear("CORE_CHAINCODE_ID_NAME");
31+
}
32+
2733
@Test
2834
void testStartInvocationTaskManagerAndRequestObserverNull() throws IOException {
2935
environmentVariables.set("CORE_CHAINCODE_ID_NAME", "mycc");

0 commit comments

Comments
 (0)