Replace checkstyle with PMD

Update Java language version to 11, which has been the target runtime
and documented as the required version since v2.1.

Signed-off-by: Mark S. Lewis <[email protected]>

Author: bestbeforetoday

build.gradle

@@ -50,12 +50,13 @@ subprojects {
     version = rootProject.version
 
     java {
-        sourceCompatibility = JavaVersion.VERSION_1_8
+        sourceCompatibility = JavaVersion.VERSION_11
+        targetCompatibility = JavaVersion.VERSION_11
     }
 
     compileJava {
         if (javaCompiler.get().metadata.languageVersion.canCompileOrRun(10)) {
-            options.release = 8
+            options.release = 11
         }
     }
 

ci/checkstyle/checkstyle.xml

@@ -40,8 +40,8 @@ RUN gradle \
     fabric-chaincode-shim:publishToMavenLocal \
     -x javadoc \
     -x test \
-    -x checkstyleMain \
-    -x checkstyleTest
+    -x pmdMain \
+    -x pmdTest
 
 WORKDIR /root/chaincode-java 
 # Run the Gradle and Maven commands to generate the wrapper variants

ci/checkstyle/java-copyright-header.txt

@@ -7,7 +7,14 @@ group 'org.hyperledger.fabric-chaincode-java'
 version '1.0-SNAPSHOT'
 
 java {
-    sourceCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11
+}
+
+compileJava {
+    if (javaCompiler.get().metadata.languageVersion.canCompileOrRun(10)) {
+        options.release = 11
+    }
 }
 
 repositories {

fabric-chaincode-docker/Dockerfile

@@ -7,7 +7,7 @@
 	<properties>
 
 		<!-- Generic properties -->
-		<java.version>8</java.version>
+		<java.version>11</java.version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 

fabric-chaincode-integration-test/src/contracts/bare-gradle/build.gradle

@@ -7,12 +7,13 @@ group 'org.hyperledger.fabric-chaincode-java'
 version '1.0-SNAPSHOT'
 
 java {
-    sourceCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11
 }
 
 compileJava {
     if (javaCompiler.get().metadata.languageVersion.canCompileOrRun(10)) {
-        options.release = 8
+        options.release = 11
     }
 }
 

fabric-chaincode-integration-test/src/contracts/bare-maven/pom.xml

@@ -7,12 +7,13 @@ group 'org.hyperledger.fabric-chaincode-java'
 version '1.0-SNAPSHOT'
 
 java {
-    sourceCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11
 }
 
 compileJava {
     if (javaCompiler.get().metadata.languageVersion.canCompileOrRun(10)) {
-        options.release = 8
+        options.release = 11
     }
 }
 

fabric-chaincode-integration-test/src/contracts/fabric-ledger-api/build.gradle

@@ -22,7 +22,7 @@ public static void setUp() throws Exception {
     }
 
     @Test
-    public void TestInstall() {
+    public void testInstall() {
 
         InvokeHelper helper = InvokeHelper.newHelper("baregradlecc", "sachannel");
         String text = helper.invoke("org1", "whoami");

fabric-chaincode-integration-test/src/contracts/fabric-shim-api/build.gradle

@@ -23,7 +23,7 @@ public static void setUp() throws Exception {
     }
 
     @Test
-    public void TestLedgers() {
+    public void testLedgers() {
         InvokeHelper helper = InvokeHelper.newHelper("ledgercc", "sachannel");
 
         String text = helper.invoke("org1", "accessLedgers");