Fix ESLint errors with new typescript-eslint (#695)

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>

Author: bestbeforetoday

node/package.json

@@ -47,8 +47,8 @@
         "@types/google-protobuf": "^3.15.12",
         "@types/jest": "^29.5.12",
         "@types/node": "^18.19.22",
-        "@typescript-eslint/eslint-plugin": "^7.1.1",
-        "@typescript-eslint/parser": "^7.1.1",
+        "@typescript-eslint/eslint-plugin": "~7.3.1",
+        "@typescript-eslint/parser": "~7.3.1",
         "eslint": "^8.57.0",
         "eslint-config-prettier": "^9.1.0",
         "eslint-plugin-jest": "^27.9.0",
@@ -58,6 +58,6 @@
         "prettier": "^3.2.5",
         "ts-jest": "^29.1.2",
         "typedoc": "^0.25.11",
-        "typescript": "~5.3.3"
+        "typescript": "~5.4.2"
     }
 }

node/src/blockeventsrequest.ts

@@ -231,8 +231,8 @@ function mapAsyncIterator<T, R>(iterator: AsyncIterator<T>, map: (element: T) =>
 
 function getBlock<T>(response: peer.DeliverResponse, getter: () => T | null | undefined): T {
     if (response.getTypeCase() === peer.DeliverResponse.TypeCase.STATUS) {
-        throw new Error(`Unexpected status response: ${response.getStatus()}`);
+        throw new Error(`Unexpected status response: ${String(response.getStatus())}`);
     }
     const block = getter();
-    return assertDefined(block, `Unexpected deliver response type: ${response.getTypeCase()}`);
+    return assertDefined(block, `Unexpected deliver response type: ${String(response.getTypeCase())}`);
 }

node/src/commiterror.ts

@@ -38,7 +38,7 @@ export class CommitError extends Error {
 
 export function newCommitError(status: Status): CommitError {
     return new CommitError({
-        message: `Transaction ${status.transactionId} failed to commit with status code ${status.code} (${StatusNames[status.code]})`,
+        message: `Transaction ${status.transactionId} failed to commit with status code ${String(status.code)} (${StatusNames[status.code]})`,
         code: status.code,
         transactionId: status.transactionId,
     });

node/src/testutils.test.ts

@@ -201,31 +201,31 @@ export class MockGatewayGrpcClient implements GatewayGrpcClient {
     }
 
     mockCommitStatusError(err: grpc.ServiceError): void {
-        this.#commitStatusMock.mockImplementation(fakeUnaryCall(err, undefined));
+        this.#commitStatusMock.mockImplementation(fakeUnaryCall<gateway.CommitStatusResponse>(err, undefined));
     }
 
     mockEndorseResponse(response: gateway.EndorseResponse): void {
         this.#endorseMock.mockImplementation(fakeUnaryCall(undefined, response));
     }
 
     mockEndorseError(err: grpc.ServiceError): void {
-        this.#endorseMock.mockImplementation(fakeUnaryCall(err, undefined));
+        this.#endorseMock.mockImplementation(fakeUnaryCall<gateway.EndorseResponse>(err, undefined));
     }
 
     mockEvaluateResponse(response: gateway.EvaluateResponse): void {
         this.#evaluateMock.mockImplementation(fakeUnaryCall(undefined, response));
     }
 
     mockEvaluateError(err: grpc.ServiceError): void {
-        this.#evaluateMock.mockImplementation(fakeUnaryCall(err, undefined));
+        this.#evaluateMock.mockImplementation(fakeUnaryCall<gateway.EvaluateResponse>(err, undefined));
     }
 
     mockSubmitResponse(response: gateway.SubmitResponse): void {
         this.#submitMock.mockImplementation(fakeUnaryCall(undefined, response));
     }
 
     mockSubmitError(err: grpc.ServiceError): void {
-        this.#submitMock.mockImplementation(fakeUnaryCall(err, undefined));
+        this.#submitMock.mockImplementation(fakeUnaryCall<gateway.SubmitResponse>(err, undefined));
     }
 
     mockChaincodeEventsResponse(stream: ServerStreamResponse<gateway.ChaincodeEventsResponse>): void {

scenario/node/package.json

@@ -28,14 +28,14 @@
         "@cucumber/cucumber": "^10.3.1",
         "@tsconfig/node18": "^18.2.2",
         "@types/node": "^18.19.22",
-        "@typescript-eslint/eslint-plugin": "^7.1.1",
-        "@typescript-eslint/parser": "^7.1.1",
+        "@typescript-eslint/eslint-plugin": "~7.3.1",
+        "@typescript-eslint/parser": "~7.3.1",
         "cucumber-console-formatter": "^1.0.0",
         "eslint": "^8.57.0",
         "eslint-config-prettier": "^9.1.0",
         "expect": "^29.7.0",
         "npm-run-all": "^4.1.5",
         "prettier": "^3.2.5",
-        "typescript": "~5.3.3"
+        "typescript": "~5.4.2"
     }
 }

scenario/node/src/transactioninvocation.ts

@@ -93,7 +93,7 @@ export class TransactionInvocation {
         this.blockNumber = status.blockNumber;
 
         if (status.code !== StatusCode.VALID) {
-            throw new Error(`Transaction commit failed with status: ${status.code}`);
+            throw new Error(`Transaction commit failed with status: ${String(status.code)}`);
         }
 
         return submitted.getResult();