Correctly handle error when no committers are specified (#568) (#569)

Signed-off-by: sapthasurendran <[email protected]>
(cherry picked from commit 8cfd49d)

Co-authored-by: sapthasurendran <[email protected]>

Author: mergify[bot]

fabric-common/lib/Commit.js

@@ -182,6 +182,11 @@ class Commit extends Proposal {
 		} else if (targets) {
 			logger.debug('%s - sending to the targets', method);
 			const committers = this.channel.getTargetCommitters(targets);
+
+			if (committers.length === 0) {
+				throw new Error('Unable to find any target committers');
+			}
+
 			let result;
 			for (const committer of committers) {
 				const isConnected = await committer.checkConnection();

fabric-common/test/Commit.js

@@ -106,6 +106,14 @@ describe('Commit', () => {
 	});
 
 	describe('#send', () => {
+		it('throws if targets committers is missing', async () => {
+			commit.build(idx);
+			const request = {
+				targets: []
+			};
+			await commit.sign(idx);
+			await commit.send(request).should.be.rejectedWith('Unable to find any target committers');
+		});
 		it('throws if targets is missing', async () => {
 			endorsement._proposalResponses = [];
 			endorsement._proposalResponses.push(proposalResponse);