[applicationpb] Update ASN.1 schema with extension marker (#80)

#### Type of change

- Bug fix

#### Description

- Add extensibility markers (...) to all SEQUENCE types for forward
compatibility
  - Remove redundant OPTIONAL keyword (DEFAULT already implies optional)
  - Fix missing commas and quoted integer default values

Sources:
  - https://www.oss.com/asn1/resources/asn1-faq.html#default
-
https://pkg.go.dev/encoding/asn1#:~:text=The%20following%20tags%20on%20struct,specifies%20that%20an%20additional%2C%20explicit
 
#### Additional details (Optional)

 - using asn1c compiler to parse and validate the syntax

#### Related issues

  - resolves #79

Signed-off-by: Senthilnathan <cendhu@gmail.com>

Author: cendhu

Makefile

@@ -75,12 +75,17 @@ clean:
 	-@rm -rf $(BUILD_DIR)
 
 ## Run code linter
-lint: lint-proto FORCE
+lint: lint-proto lint-asn1 FORCE
 	@echo "Running Go Linters..."
 	golangci-lint run --color=always --new-from-rev=main --timeout=4m
 	@echo "Running License Header Linters..."
 	scripts/license-lint.sh
 
+## Run ASN.1 schema linter
+lint-asn1: FORCE
+	@echo "Running ASN.1 schema linters..."
+	@asn1c -EP $(shell find ${project_dir}/api -name '*.asn')
+
 # https://www.gnu.org/software/make/manual/html_node/Force-Targets.html
 # If a rule has no prerequisites or recipe, and the target of the rule is a nonexistent file,
 # then make imagines this target to have been updated whenever its rule is run.

api/applicationpb/asn1_tx_schema.asn

@@ -4,21 +4,29 @@
 -- Any change to [*protoblocktx.Tx] requires a change to this schema.
 -- Quick reference: https://www.oss.com/asn1/resources/asn1-made-simple/asn1-quick-reference.html
 
+FabricXTxSchema DEFINITIONS AUTOMATIC TAGS ::= BEGIN
+
 TxWithNamespace ::= SEQUENCE {
     txID             UTF8String,
     namespaceID      UTF8String,
     namespaceVersion INTEGER,
     reads            SEQUENCE OF SEQUENCE {
         key     OCTET STRING,
-        version INTEGER OPTIONAL DEFAULT "-1"
+        version INTEGER DEFAULT -1,
+        ...
     },
     readWrites       SEQUENCE OF SEQUENCE {
         key     OCTET STRING,
-        value   OCTET STRING
-        version INTEGER OPTIONAL DEFAULT "-1",
+        value   OCTET STRING,
+        version INTEGER DEFAULT -1,
+        ...
     },
     writes           SEQUENCE OF SEQUENCE {
         key   OCTET STRING,
-        value OCTET STRING
-    }
+        value OCTET STRING,
+        ...
+    },
+    ...
 }
+
+END

scripts/install-dev-dependencies.sh

@@ -39,9 +39,13 @@ echo "Extracting protoc to $HOME/bin"
 unzip -jo "${protoc_zip_download_path}" 'bin/*' -d "$HOME/bin"
 rm -rf "${download_dir}"
 
-if which apt >/dev/null 2>&1; then
-  # Required for "duration" protobuf.
-  sudo apt install -y libprotobuf-dev
+# Install platform-specific dependencies.
+# asn1c is used to lint ASN.1 schema files.
+if [ "$protoc_os" = "linux" ]; then
+  # libprotobuf-dev is required for "duration" protobuf.
+  sudo apt install -y libprotobuf-dev asn1c
+else
+  brew install asn1c
 fi
 
 echo