2.5 fix error parsing addressoverrides (#5400)

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>

Author: pfi79

core/deliverservice/config.go

@@ -11,10 +11,10 @@ import (
 	"io/ioutil"
 	"time"
 
+	"github.com/hyperledger/fabric/common/viperutil"
 	"github.com/hyperledger/fabric/core/config"
 	"github.com/hyperledger/fabric/internal/pkg/comm"
 	"github.com/hyperledger/fabric/internal/pkg/peer/orderers"
-
 	"github.com/pkg/errors"
 	"github.com/spf13/viper"
 )
@@ -63,7 +63,7 @@ func GlobalConfig() *DeliverServiceConfig {
 
 func LoadOverridesMap() (map[string]*orderers.Endpoint, error) {
 	var overrides []AddressOverride
-	err := viper.UnmarshalKey("peer.deliveryclient.addressOverrides", &overrides)
+	err := viper.UnmarshalKey("peer.deliveryclient.addressOverrides", &overrides, viper.DecodeHook(viperutil.YamlStringToStructHook(overrides)))
 	if err != nil {
 		return nil, errors.WithMessage(err, "could not unmarshal peer.deliveryclient.addressOverrides")
 	}

core/deliverservice/config_test.go

@@ -11,14 +11,15 @@ import (
 	"io/ioutil"
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/require"
-
 	"github.com/hyperledger/fabric/core/deliverservice"
+	"github.com/hyperledger/fabric/internal/peer/common"
 	"github.com/hyperledger/fabric/internal/pkg/comm"
 	"github.com/spf13/viper"
+	"github.com/stretchr/testify/require"
 )
 
 func TestSecureOptsConfig(t *testing.T) {
@@ -161,6 +162,37 @@ func TestLoadOverridesMap(t *testing.T) {
 		require.Equal(t, "addressTo2", ep2.Address)
 	})
 
+	t.Run("GreenPath With Env", func(t *testing.T) {
+		t.Setenv("CORE_PEER_DELIVERYCLIENT_ADDRESSOVERRIDES", "[{from: addressFrom1, to: addressTo1, caCertsFile: testdata/cert.pem}"+
+			", {from: addressFrom2, to: addressTo2, caCertsFile: testdata/cert.pem}]")
+		config := `
+                  peer:
+                    deliveryclient:
+                      addressOverrides:
+                `
+
+		viper.Reset()
+
+		viper.SetEnvPrefix(common.CmdRoot)
+		viper.AllowEmptyEnv(true)
+		viper.AutomaticEnv()
+		replacer := strings.NewReplacer(".", "_")
+		viper.SetEnvKeyReplacer(replacer)
+
+		viper.SetConfigType("yaml")
+		err := viper.ReadConfig(bytes.NewBuffer([]byte(config)))
+		require.NoError(t, err)
+		res, err := deliverservice.LoadOverridesMap()
+		require.NoError(t, err)
+		require.Len(t, res, 2)
+		ep1, ok := res["addressFrom1"]
+		require.True(t, ok)
+		require.Equal(t, "addressTo1", ep1.Address)
+		ep2, ok := res["addressFrom2"]
+		require.True(t, ok)
+		require.Equal(t, "addressTo2", ep2.Address)
+	})
+
 	t.Run("MissingCAFiles", func(t *testing.T) {
 		config := `
                   peer: