Make CI rules consistent, include pkg in test, and make start completion checking more intuitive

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>

Author: peterbroadhurst

.golangci.yml

@@ -12,17 +12,18 @@ linters-settings:
     values:
       regexp:
         COMPANY: .*
+        YEAR: '\d\d\d\d(-\d\d\d\d)?'
     template: |-
       Copyright © {{ YEAR }} {{ COMPANY }}
-
+      
       SPDX-License-Identifier: Apache-2.0
-
+      
       Licensed under the Apache License, Version 2.0 (the "License");
       you may not use this file except in compliance with the License.
       You may obtain a copy of the License at
-
+      
           http://www.apache.org/licenses/LICENSE-2.0
-
+      
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

Makefile

@@ -1,5 +1,5 @@
 VGO=go
-GOFILES := $(shell find cmd internal -name '*.go' -print)
+GOFILES := $(shell find cmd pkg internal -name '*.go' -print)
 GOBIN := $(shell $(VGO) env GOPATH)/bin
 LINT := $(GOBIN)/golangci-lint
 MOCKERY := $(GOBIN)/mockery
@@ -12,7 +12,7 @@ GOGC=30
 
 all: build test go-mod-tidy
 test: deps lint
-		$(VGO) test ./internal/... ./cmd/... -cover -coverprofile=coverage.txt -covermode=atomic -timeout=30s
+		$(VGO) test ./pkg/... ./internal/... ./cmd/... -cover -coverprofile=coverage.txt -covermode=atomic -timeout=30s
 coverage.html:
 		$(VGO) tool cover -html=coverage.txt
 coverage: test coverage.html

go.sum

@@ -104,8 +104,6 @@ github.com/hyperledger/firefly-common v1.5.9 h1:Z1+SuKNYJ8hPKQ5CvcsMg6r/E4RyW6wb
 github.com/hyperledger/firefly-common v1.5.9/go.mod h1:1Xawm5PUhxT7k+CL/Kr3i1LE3cTTzoQwZMLimvlW8rs=
 github.com/hyperledger/firefly-signer v1.1.21 h1:r7cTOw6e/6AtiXLf84wZy6Z7zppzlc191HokW2hv4N4=
 github.com/hyperledger/firefly-signer v1.1.21/go.mod h1:axrlSQeKrd124UdHF5L3MkTjb5DeTcbJxJNCZ3JmcWM=
-github.com/hyperledger/firefly-transaction-manager v1.4.3-0.20251210154150-19fe03d63b4f h1:i38DovJn5Dmme2Ltye4iv51UEwLpWkzfcQ78lGC/i9k=
-github.com/hyperledger/firefly-transaction-manager v1.4.3-0.20251210154150-19fe03d63b4f/go.mod h1:1kbYt8ofDXqfwC02vwV/HoOjmiv0IuT9UkJ//bbrliE=
 github.com/hyperledger/firefly-transaction-manager v1.4.3 h1:/RltpJCIH8VsB8cTEICbGJkyc1CGPpJ2grG3kV+tdc8=
 github.com/hyperledger/firefly-transaction-manager v1.4.3/go.mod h1:1kbYt8ofDXqfwC02vwV/HoOjmiv0IuT9UkJ//bbrliE=
 github.com/imdario/mergo v0.3.11/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA=