Support non-reconnecting websockets

chrisbygrave · chrisbygrave · commit 3e798dd72e09 · 2023-02-01T20:48:55.000Z
- treat a recconectDelay of -1 as meaning do not attempt to reconnect
- reconnecting is not always desirable - for example when using firefly-sdk as a websocket proxy

Signed-off-by: Chris Bygrave &lt;chris.bygrave@kaleido.io&gt;
diff --git a/lib/websocket.ts b/lib/websocket.ts
@@ -148,7 +148,11 @@ export class FireFlyWebSocket {
     if (!this.reconnectTimer) {
       this.close();
       this.logger.error(`Websocket closed: ${msg}`);
-      this.reconnectTimer = setTimeout(() => this.connect(), this.options.reconnectDelay);
+      if (this.options.reconnectDelay === -1) {
+        // do not attempt to reconnect
+      } else {
+        this.reconnectTimer = setTimeout(() => this.connect(), this.options.reconnectDelay);
+      }
     }
   }
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hyperledger/firefly-sdk",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "Client SDK for Hyperledger FireFly",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,11 @@ export class FireFlyWebSocket {`
`148`	`148`	`if (!this.reconnectTimer) {`
`149`	`149`	`this.close();`
`150`	`150`	this.logger.error(`Websocket closed: ${msg}`);
`151`		`- this.reconnectTimer = setTimeout(() => this.connect(), this.options.reconnectDelay);`
	`151`	`+ if (this.options.reconnectDelay === -1) {`
	`152`	`+ // do not attempt to reconnect`
	`153`	`+ } else {`
	`154`	`+ this.reconnectTimer = setTimeout(() => this.connect(), this.options.reconnectDelay);`
	`155`	`+ }`
`152`	`156`	`}`
`153`	`157`	`}`
`154`	`158`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@hyperledger/firefly-sdk",`
`3`		`- "version": "1.2.5",`
	`3`	`+ "version": "1.2.6",`
`4`	`4`	`"description": "Client SDK for Hyperledger FireFly",`
`5`	`5`	`"main": "dist/index.js",`
`6`	`6`	`"types": "dist/index.d.ts",`