Merge pull request #31 from kaleido-io/ack

Only ack messages if handler promise is successful

Author: gabriel-indik

lib/firefly.ts

@@ -397,8 +397,9 @@ export default class FireFly extends HttpBase {
     };
 
     const handler: FireFlyWebSocketCallback = (socket, event) => {
-      this.queue = this.queue.finally(() => {
-        callback(socket, event);
+      this.queue = this.queue.finally(() => callback(socket, event));
+      this.queue.then(() => {
+        socket.ack(event);
       });
     };
 

lib/websocket.ts

@@ -19,7 +19,7 @@ function buildEphemeralQueryParams(sub: FireFlyEphemeralSubscription) {
 }
 
 export interface FireFlyWebSocketCallback {
-  (socket: FireFlyWebSocket, data: FireFlyEventDelivery): void;
+  (socket: FireFlyWebSocket, data: FireFlyEventDelivery): void | Promise<void>;
 }
 
 export class FireFlyWebSocket {