No subscription (#4)

* updates

Author: marosset

README.md

@@ -14,8 +14,8 @@ jobs:
     - uses: deislabs/hyperlight-workflow-setup@dev
         with:
           rust-toolchain: "1.74.0"
-        env:
-          PAT: $ {{ secrets.ADO_CARGO_RO_PAT }}
+          azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
+          azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
 ```
 
 ## Inputs
@@ -25,17 +25,15 @@ jobs:
 | Name | Description |
 | ---- | ----------- |
 | `rust-toolchain` | The rust toolchain version to use. |
-
-### Environment Variables
-
-| Name | Description |
-| ---- | ----------- |
-| `PAT` | The Personal Access Token to use for logging into the Hyperlight cargo feeds in Azure DevOps. |
+| `azure-client-id` | The Azure Client ID to use for logging into the Hyperlight cargo feeds in Azure DevOps. |
+| `azure-tenant-id` | The Azure Tenant ID to use for logging into the Hyperlight cargo feeds in Azure DevOps. |
 
 ## Overview
 
 This action performs the following steps:
 
+- Logs into the Azure account using the provided client ID and tenant ID.
+  - The account used to log in must be configred for OIDC authentication from GitHub workflows.
 - Runs `cargo login` to log into the Hyperlight cargo feeds in Azure DevOps.
 - Installs the Rust tool chain at the specified version.
 - Installs additional rust components like clippy, rustfmt, ect

action.yml

@@ -14,9 +14,6 @@ inputs:
   azure-tenant-id:
     description: 'TenantId of the Azure Service principal created.'
     required: true
-  azure-subscription-id:
-    description: 'Azure subscriptionId'
-    required: false
 
 runs:
   using: composite
@@ -42,17 +39,12 @@ runs:
       shell: bash
 
     - name: Azure CLI login (Linux)
-      uses: azure/login@v1
+      uses: azure/login@v2
       if: runner.os == 'Linux'
       with:
         client-id: ${{ inputs.azure-client-id }}
         tenant-id: ${{ inputs.azure-tenant-id }}
-        subscription-id: ${{ inputs.azure-subscription-id }} 
-
-    - name: Cargo login
-      if: ${{ runner.os == 'Linux' }}
-      run: just cargo-login
-      shell: bash
+        allow-no-subscriptions: true
 
     - name: Cargo login
       if: ${{ runner.os == 'Linux' }}
@@ -115,12 +107,12 @@ runs:
     ### Windows setup ###
 
     - name: Azure CLI login (Window)
-      uses: azure/login@v1
+      uses: azure/login@v2
       if: runner.os == 'Windows'
       with:
         client-id: ${{ inputs.azure-client-id }}
         tenant-id: ${{ inputs.azure-tenant-id }}
-        subscription-id: ${{ inputs.azure-subscription-id }} 
+        allow-no-subscriptions: true
 
     - name: Cargo login (Windows)
       if: ${{ (runner.os == 'Windows') }}