Remove runtime class #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Davies <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Hyperlight Kubernetes scheduling model by removing RuntimeClasses and tolerations in favor of direct nodeSelector-based scheduling. This change streamlines the deployment approach by relying solely on node labels and resource requests for proper pod placement and device injection.
Key changes:
- Removed RuntimeClass resources (hyperlight-kvm and hyperlight-mshv) from all manifests
- Removed tolerations from all pod specifications and device plugin DaemonSet
- Removed node taints from setup scripts (both local and Azure deployments)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hyperlight-app/k8s/deployment.yaml | Removed tolerations from both KVM and MSHV deployment specs |
| hyperlight-app/k8s/deployment-mshv.yaml | Removed tolerations from MSHV deployment spec |
| hyperlight-app/k8s/deployment-kvm.yaml | Removed tolerations from KVM deployment spec |
| docs/architecture.md | Updated documentation to replace RuntimeClasses section with Scheduling section, removed taints documentation, clarified new nodeSelector-based approach |
| device-plugin/Dockerfile | Updated comments to clarify root user requirement (no functional change) |
| deploy/manifests/examples/test-pod-mshv.yaml | Replaced runtimeClassName with nodeSelector |
| deploy/manifests/examples/test-pod-kvm.yaml | Replaced runtimeClassName with nodeSelector |
| deploy/manifests/examples/deployment-mshv.yaml | Replaced runtimeClassName with nodeSelector |
| deploy/manifests/examples/deployment-kvm.yaml | Replaced runtimeClassName with nodeSelector |
| deploy/manifests/device-plugin.yaml | Removed RuntimeClass resources and tolerations from device plugin DaemonSet |
| deploy/local/setup.sh | Removed node taint configuration from local setup |
| deploy/local/device-plugin.yaml | Removed RuntimeClass resources and tolerations from local device plugin manifest |
| deploy/azure/setup.sh | Removed --node-taints arguments from nodepool creation commands |
| README.md | Updated example to use nodeSelector instead of runtimeClassName |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.