Fix confusing log message when checking present hypervisor (#422)

* Removes the word 'Error' from non-error log messages when checking if specific hypervisors exist. This caused confusion if both kvm and mshv cargo features were enabled

Signed-off-by: Ludvig Liljenberg <[email protected]>

* Use Mshv::new() instead of Mshv::open_with_cloexec() to avoid manually needing to close fd

Signed-off-by: Ludvig Liljenberg <[email protected]>

---------

Signed-off-by: Ludvig Liljenberg <[email protected]>

Author: ludfjig

src/hyperlight_host/src/hypervisor/hyperv_linux.rs

@@ -271,15 +271,10 @@ mod debug {
 /// and functional.
 #[instrument(skip_all, parent = Span::current(), level = "Trace")]
 pub(crate) fn is_hypervisor_present() -> bool {
-    match Mshv::open_with_cloexec(true) {
-        Ok(fd) => {
-            unsafe {
-                libc::close(fd);
-            } // must explicitly close fd to avoid a leak
-            true
-        }
-        Err(e) => {
-            log::info!("Error creating MSHV object: {:?}", e);
+    match Mshv::new() {
+        Ok(_) => true,
+        Err(_) => {
+            log::info!("MSHV is not available on this system");
             false
         }
     }

src/hyperlight_host/src/hypervisor/kvm.rs

@@ -59,7 +59,7 @@ pub(crate) fn is_hypervisor_present() -> bool {
             }
         }
     } else {
-        log::info!("Error creating KVM object");
+        log::info!("KVM is not available on this system");
         false
     }
 }

src/hyperlight_host/src/hypervisor/windows_hypervisor_platform.rs

@@ -53,7 +53,10 @@ pub(crate) fn is_hypervisor_present() -> bool {
         )
     } {
         Ok(_) => unsafe { capability.HypervisorPresent.as_bool() },
-        Err(_) => false,
+        Err(_) => {
+            log::info!("Windows Hypervisor Platform is not available on this system");
+            false
+        }
     }
 }