Fix clippy warnings for unrelated work

Signed-off-by: Doru Blânzeanu <[email protected]>

Author: dblnz

src/hyperlight_host/src/hypervisor/surrogate_process.rs

@@ -83,15 +83,13 @@ impl Drop for SurrogateProcess {
                         "Failed to return surrogate process to surrogate process manager when dropping : {:?}",
                         e
                     );
-                    return;
                 }
             },
             Err(e) => {
                 tracing::error!(
                     "Failed to get surrogate process manager when dropping SurrogateProcess: {:?}",
                     e
                 );
-                return;
             }
         }
     }

src/hyperlight_host/src/mem/layout.rs

@@ -224,18 +224,24 @@ impl SandboxMemoryLayout {
     pub(crate) const PML4_OFFSET: usize = 0x0000;
     /// The offset into the sandbox's memory where the Page Directory Pointer
     /// Table starts.
+    #[cfg(feature = "init-paging")]
     pub(super) const PDPT_OFFSET: usize = 0x1000;
     /// The offset into the sandbox's memory where the Page Directory starts.
+    #[cfg(feature = "init-paging")]
     pub(super) const PD_OFFSET: usize = 0x2000;
     /// The offset into the sandbox's memory where the Page Tables start.
+    #[cfg(feature = "init-paging")]
     pub(super) const PT_OFFSET: usize = 0x3000;
     /// The address (not the offset) to the start of the page directory
+    #[cfg(feature = "init-paging")]
     pub(super) const PD_GUEST_ADDRESS: usize = Self::BASE_ADDRESS + Self::PD_OFFSET;
     /// The address (not the offset) into sandbox memory where the Page
     /// Directory Pointer Table starts
+    #[cfg(feature = "init-paging")]
     pub(super) const PDPT_GUEST_ADDRESS: usize = Self::BASE_ADDRESS + Self::PDPT_OFFSET;
     /// The address (not the offset) into sandbox memory where the Page
     /// Tables start
+    #[cfg(feature = "init-paging")]
     pub(super) const PT_GUEST_ADDRESS: usize = Self::BASE_ADDRESS + Self::PT_OFFSET;
     /// The maximum amount of memory a single sandbox will be allowed.
     /// The addressable virtual memory with current paging setup is virtual address 0x0 - 0x40000000 (excl.),

src/hyperlight_host/src/mem/mgr.rs

@@ -340,6 +340,9 @@ impl SandboxMemoryManager<ExclusiveSharedMemory> {
             shared_mem.write_u64(offset, load_addr_u64)?;
         }
 
+        // The load method returns a LoadInfo which can also be a different type once the
+        // `unwind_guest` feature is enabled.
+        #[allow(clippy::let_unit_value)]
         let load_info = exe_info.load(
             load_addr.clone().try_into()?,
             &mut shared_mem.as_mut_slice()[layout.get_guest_code_offset()..],

src/hyperlight_host/src/sandbox/initialized_multi_use.rs

@@ -136,6 +136,7 @@ impl MultiUseSandbox {
     /// `rgn.region_type` is ignored, since guest PTEs are not created
     /// for the new memory.
     ///
+    /// # Safety
     /// It is the caller's responsibility to ensure that the host side
     /// of the region remains intact and is not written to until this
     /// mapping is removed, either due to the destruction of the
@@ -161,6 +162,7 @@ impl MultiUseSandbox {
     /// Map the contents of a file into the guest at a particular address
     ///
     /// Returns the length of the mapping
+    #[allow(dead_code)]
     #[instrument(err(Debug), skip(self, _fp, _guest_base), parent = Span::current())]
     pub(crate) fn map_file_cow(&mut self, _fp: &Path, _guest_base: u64) -> Result<u64> {
         #[cfg(windows)]