Skip to content

Commit 407b7f5

Browse files
committed
Remove OutBhandler and MemAccessHandler traits from evolve and provide new values to vm.initialise
Signed-off-by: Simon Davies <[email protected]>
1 parent ddd588b commit 407b7f5

File tree

1 file changed

+3
-14
lines changed

1 file changed

+3
-14
lines changed

src/hyperlight_host/src/sandbox/uninitialized_evolve.rs

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ use super::mem_access::dbg_mem_access_handler_wrapper;
2727
use super::uninitialized::SandboxRuntimeConfig;
2828
use crate::HyperlightError::NoHypervisorFound;
2929
use crate::hypervisor::Hypervisor;
30-
use crate::hypervisor::handlers::{MemAccessHandlerCaller, OutBHandlerCaller};
3130
use crate::mem::exe::LoadInfo;
3231
use crate::mem::layout::SandboxMemoryLayout;
3332
use crate::mem::mgr::SandboxMemoryManager;
@@ -41,8 +40,6 @@ use crate::sandbox::TraceInfo;
4140
#[cfg(gdb)]
4241
use crate::sandbox::config::DebugInfo;
4342
use crate::sandbox::host_funcs::FunctionRegistry;
44-
use crate::sandbox::mem_access::mem_access_handler_wrapper;
45-
use crate::sandbox::outb::outb_handler_wrapper;
4643
use crate::sandbox::{HostSharedMemory, MemMgrWrapper};
4744
#[cfg(target_os = "linux")]
4845
use crate::signal_handlers::setup_signal_handlers;
@@ -69,8 +66,6 @@ where
6966
Arc<Mutex<FunctionRegistry>>,
7067
MemMgrWrapper<HostSharedMemory>,
7168
Box<dyn Hypervisor>,
72-
Arc<Mutex<dyn OutBHandlerCaller>>,
73-
Arc<Mutex<dyn MemAccessHandlerCaller>>,
7469
RawPtr,
7570
) -> Result<ResSandbox>,
7671
{
@@ -82,7 +77,6 @@ where
8277
&u_sbox.rt_cfg,
8378
u_sbox.load_info,
8479
)?;
85-
let outb_hdl = outb_handler_wrapper(hshm.clone(), u_sbox.host_funcs.clone());
8680

8781
let seed = {
8882
let mut rng = rand::rng();
@@ -94,7 +88,6 @@ where
9488
};
9589

9690
let page_size = u32::try_from(page_size::get())?;
97-
let mem_access_hdl = mem_access_handler_wrapper(hshm.clone());
9891

9992
#[cfg(gdb)]
10093
let dbg_mem_access_hdl = dbg_mem_access_handler_wrapper(hshm.clone());
@@ -106,8 +99,8 @@ where
10699
peb_addr,
107100
seed,
108101
page_size,
109-
outb_hdl.clone(),
110-
mem_access_hdl.clone(),
102+
hshm.clone(),
103+
u_sbox.host_funcs.clone(),
111104
u_sbox.max_guest_log_level,
112105
#[cfg(gdb)]
113106
dbg_mem_access_hdl,
@@ -122,23 +115,19 @@ where
122115
u_sbox.host_funcs,
123116
hshm,
124117
vm,
125-
outb_hdl,
126-
mem_access_hdl,
127118
RawPtr::from(dispatch_function_addr),
128119
)
129120
}
130121

131122
#[instrument(err(Debug), skip_all, parent = Span::current(), level = "Trace")]
132123
pub(super) fn evolve_impl_multi_use(u_sbox: UninitializedSandbox) -> Result<MultiUseSandbox> {
133-
evolve_impl(u_sbox, |hf, hshm, vm, out_hdl, mem_hdl, dispatch_ptr| {
124+
evolve_impl(u_sbox, |hf, hshm, vm, dispatch_ptr| {
134125
#[cfg(gdb)]
135126
let dbg_mem_wrapper = dbg_mem_access_handler_wrapper(hshm.clone());
136127
Ok(MultiUseSandbox::from_uninit(
137128
hf,
138129
hshm,
139130
vm,
140-
out_hdl,
141-
mem_hdl,
142131
dispatch_ptr,
143132
#[cfg(gdb)]
144133
dbg_mem_wrapper,

0 commit comments

Comments
 (0)