Skip to content

Commit 63667c0

Browse files
committed
[common/mem] remove legacy fields from GuestStackData
We no longer have kernel stack and boot stacks, so we can remove these fields. Also, removed some legacy comment. Signed-off-by: danbugs <[email protected]>
1 parent 7def1ef commit 63667c0

File tree

2 files changed

+2
-21
lines changed

2 files changed

+2
-21
lines changed

src/hyperlight_common/src/mem.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ pub struct GuestStackData {
4646
pub minUserStackAddress: u64,
4747
/// This is the user stack pointer
4848
pub userStackAddress: u64,
49-
/// This is the stack pointer for the kernel mode stack
50-
pub kernelStackAddress: u64,
51-
/// This is the initial stack pointer when init is called its used before the TSS is set up
52-
pub bootStackAddress: u64,
5349
}
5450

5551
#[repr(C)]

src/hyperlight_host/src/lib.rs

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -41,30 +41,15 @@ pub mod hypervisor;
4141
/// Functionality to establish and manage an individual sandbox's
4242
/// memory.
4343
///
44-
/// The following structs are not used other than to calculate the size of the memory needed
45-
/// and also to illustrate the layout of the memory:
46-
///
47-
/// - `HostFunctionDefinitions`
48-
/// - `HostExceptionData`
49-
/// - `GuestError`
50-
/// - `CodeAndOutBPointers`
51-
/// - `InputData`
52-
/// - `OutputData`
53-
/// - `GuestHeap`
54-
/// - `GuestStack`
55-
///
56-
/// the start of the guest memory contains the page tables and is always located at the Virtual Address 0x00200000 when
57-
/// running in a Hypervisor:
58-
///
59-
/// Virtual Address
44+
/// - Virtual Address
6045
///
6146
/// 0x0000 PML4
6247
/// 0x1000 PDPT
6348
/// 0x2000 PD
6449
/// 0x3000 The guest PE code (When the code has been loaded using LoadLibrary to debug the guest this will not be
6550
/// present and code length will be zero;
6651
///
67-
/// The pointer passed to the Entrypoint in the Guest application is the ize of page table + size of code,
52+
/// - The pointer passed to the Entrypoint in the Guest application is the size of page table + size of code,
6853
/// at this address structs below are laid out in this order
6954
pub mod mem;
7055
/// Metric definitions and helpers

0 commit comments

Comments
 (0)