Make UninitializedSandbox::new take guest binary by references instead of value

Signed-off-by: Ludvig Liljenberg <[email protected]>

Author: ludfjig

fuzz/fuzz_targets/guest_call.rs

@@ -33,7 +33,7 @@ fuzz_target!(
     init: {
 
         let u_sbox = UninitializedSandbox::new(
-            GuestBinary::FilePath(simple_guest_for_fuzzing_as_string().expect("Guest Binary Missing")),
+            &GuestBinary::FilePath(simple_guest_for_fuzzing_as_string().expect("Guest Binary Missing")),
             None,
         )
         .unwrap();

fuzz/fuzz_targets/host_call.rs

@@ -32,7 +32,7 @@ static SANDBOX: OnceLock<Mutex<MultiUseSandbox>> = OnceLock::new();
 fuzz_target!(
     init: {
         let u_sbox = UninitializedSandbox::new(
-            GuestBinary::FilePath(simple_guest_for_fuzzing_as_string().expect("Guest Binary Missing")),
+            &GuestBinary::FilePath(simple_guest_for_fuzzing_as_string().expect("Guest Binary Missing")),
             None
         )
         .unwrap();

fuzz/fuzz_targets/host_print.rs

@@ -18,7 +18,7 @@ static SANDBOX: OnceLock<Mutex<MultiUseSandbox>> = OnceLock::new();
 fuzz_target!(
     init: {
         let u_sbox = UninitializedSandbox::new(
-            GuestBinary::FilePath(simple_guest_for_fuzzing_as_string().expect("Guest Binary Missing")),
+            &GuestBinary::FilePath(simple_guest_for_fuzzing_as_string().expect("Guest Binary Missing")),
             None,
         )
         .unwrap();

src/hyperlight_guest/src/guest_handle/handle.rs

@@ -30,6 +30,12 @@ pub struct GuestHandle {
     peb: Option<*mut HyperlightPEB>,
 }
 
+impl Default for GuestHandle {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl GuestHandle {
     /// Creates a new uninitialized guest state.
     pub const fn new() -> Self {

src/hyperlight_guest/src/guest_handle/host_comm.rs

@@ -102,7 +102,7 @@ impl GuestHandle {
     /// Write an error to the shared output data buffer.
     pub fn write_error(&self, error_code: ErrorCode, message: Option<&str>) {
         let guest_error: GuestError = GuestError::new(
-            error_code.clone(),
+            error_code,
             message.map_or("".to_string(), |m| m.to_string()),
         );
         let guest_error_buffer: Vec<u8> = (&guest_error)

src/hyperlight_host/benches/benchmarks.rs

@@ -23,7 +23,8 @@ use hyperlight_testing::simple_guest_as_string;
 
 fn create_uninit_sandbox() -> UninitializedSandbox {
     let path = simple_guest_as_string().unwrap();
-    UninitializedSandbox::new(GuestBinary::FilePath(path), None).unwrap()
+    let binary = GuestBinary::FilePath(path);
+    UninitializedSandbox::new(&binary, None).unwrap()
 }
 
 fn create_multiuse_sandbox() -> MultiUseSandbox {
@@ -68,7 +69,7 @@ fn guest_call_benchmark(c: &mut Criterion) {
         config.set_heap_size(SIZE as u64 * 15);
 
         let sandbox = UninitializedSandbox::new(
-            GuestBinary::FilePath(simple_guest_as_string().unwrap()),
+            &GuestBinary::FilePath(simple_guest_as_string().unwrap()),
             Some(config),
         )
         .unwrap();

src/hyperlight_host/examples/func_ctx/main.rs

@@ -26,7 +26,7 @@ fn main() {
     // test guest binary
     let sbox1: MultiUseSandbox = {
         let path = simple_guest_as_string().unwrap();
-        let u_sbox = UninitializedSandbox::new(GuestBinary::FilePath(path), None).unwrap();
+        let u_sbox = UninitializedSandbox::new(&GuestBinary::FilePath(path), None).unwrap();
         u_sbox.evolve(Noop::default())
     }
     .unwrap();

src/hyperlight_host/examples/guest-debugging/main.rs

@@ -43,7 +43,7 @@ fn main() -> hyperlight_host::Result<()> {
 
     // Create an uninitialized sandbox with a guest binary
     let mut uninitialized_sandbox = UninitializedSandbox::new(
-        hyperlight_host::GuestBinary::FilePath(
+        &hyperlight_host::GuestBinary::FilePath(
             hyperlight_testing::simple_guest_as_string().unwrap(),
         ),
         cfg, // sandbox configuration

src/hyperlight_host/examples/hello-world/main.rs

@@ -23,7 +23,7 @@ use hyperlight_host::{MultiUseSandbox, UninitializedSandbox};
 fn main() -> hyperlight_host::Result<()> {
     // Create an uninitialized sandbox with a guest binary
     let mut uninitialized_sandbox = UninitializedSandbox::new(
-        hyperlight_host::GuestBinary::FilePath(
+        &hyperlight_host::GuestBinary::FilePath(
             hyperlight_testing::simple_guest_as_string().unwrap(),
         ),
         None, // default configuration

src/hyperlight_host/examples/logging/main.rs

@@ -43,7 +43,7 @@ fn main() -> Result<()> {
         let path = hyperlight_guest_path.clone();
         let res: Result<()> = {
             // Create a new sandbox.
-            let mut usandbox = UninitializedSandbox::new(GuestBinary::FilePath(path), None)?;
+            let mut usandbox = UninitializedSandbox::new(&GuestBinary::FilePath(path), None)?;
             usandbox.register_print(fn_writer)?;
 
             // Initialize the sandbox.
@@ -77,7 +77,7 @@ fn main() -> Result<()> {
 
     // Create a new sandbox.
     let usandbox =
-        UninitializedSandbox::new(GuestBinary::FilePath(hyperlight_guest_path.clone()), None)?;
+        UninitializedSandbox::new(&GuestBinary::FilePath(hyperlight_guest_path.clone()), None)?;
 
     // Initialize the sandbox.