Run a more exhasutive clippy check

Signed-off-by: Mark Rossett <[email protected]>

Author: marosset

Justfile

@@ -176,6 +176,46 @@ clippy-apply-fix-unix:
 clippy-apply-fix-windows:
     cargo clippy --target x86_64-pc-windows-msvc --fix --all 
 
+# Generate and test all possible feature combinations for a package
+clippy-feature-combinations package target=default-target:
+    #!/usr/bin/env bash
+    set -euo pipefail
+    
+    # Get all features for the package
+    features=$(cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "{{package}}") | .features | keys[]' | grep -v default || true)
+    
+    echo "Testing {{package}} with no features..."
+    cargo clippy -p {{package}} --all-targets --no-default-features --profile={{ if target == "debug" { "dev" } else { target } }} -- -D warnings
+    
+    echo "Testing {{package}} with default features..."
+    cargo clippy -p {{package}} --all-targets --profile={{ if target == "debug" { "dev" } else { target } }} -- -D warnings
+    
+    # Test each feature individually
+    for feature in $features; do
+        echo "Testing {{package}} with feature: $feature"
+        cargo clippy -p {{package}} --all-targets --no-default-features --features "$feature" --profile={{ if target == "debug" { "dev" } else { target } }} -- -D warnings || echo "Feature $feature failed for {{package}}"
+    done
+    
+    # Test all features together
+    if [ -n "$features" ]; then
+        all_features=$(echo $features | tr '\n' ',' | sed 's/,$//')
+        echo "Testing {{package}} with all features: $all_features"
+        cargo clippy -p {{package}} --all-targets --no-default-features --features "$all_features" --profile={{ if target == "debug" { "dev" } else { target } }} -- -D warnings || echo "All features failed for {{package}}"
+    fi
+
+# Run clippy with feature combinations for all packages
+clippy-exhaustive target=default-target: (witguest-wit)
+    ./hack/clippy-package-features.sh hyperlight-host {{ target }}
+    ./hack/clippy-package-features.sh hyperlight-guest {{ target }}
+    ./hack/clippy-package-features.sh hyperlight-guest-bin {{ target }}
+    ./hack/clippy-package-features.sh hyperlight-common {{ target }}
+    ./hack/clippy-package-features.sh hyperlight-testing {{ target }}
+    just clippy-guests {{ target }}
+
+# Test a specific package with all feature combinations
+clippy-package package target=default-target: (witguest-wit)
+    ./hack/clippy-package-features.sh {{ package }} {{ target }}
+
 # Verify Minimum Supported Rust Version
 verify-msrv:
     ./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-guest-lib hyperlight-common

hack/clippy-package-features.sh

@@ -0,0 +1,71 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+# Check for required arguments
+if [[ $# -lt 2 ]]; then
+    echo "Usage: $0 <package> <target>" >&2
+    echo "Example: $0 hyperlight-host debug" >&2
+    exit 1
+fi
+
+PACKAGE="$1"
+TARGET="$2"
+
+# Convert target for cargo profile
+PROFILE=$([ "$TARGET" = "debug" ] && echo "dev" || echo "$TARGET")
+
+# Required features needed so the rust packages can compile
+if [[ "$PACKAGE" == "hyperlight-host" ]]; then
+    REQUIRED_FEATURES=("kvm" "mshv3")
+elif [[ "$PACKAGE" == "hyperlight-guest-bin" ]]; then
+    REQUIRED_FEATURES=("printf")
+else 
+    REQUIRED_FEATURES=()
+fi
+
+# Get all features for the package (excluding default and required features)
+# Always exclude "default", and exclude any required features using jq
+features=$(cargo metadata --format-version 1 --no-deps | jq -r --arg pkg "$PACKAGE" '.packages[] | select(.name == $pkg) | .features | keys[] | select(. != "default" and (IN($ARGS.positional[])|not))' --args "${REQUIRED_FEATURES[@]}" || true)
+
+# Convert required features array to comma-separated string for cargo
+if [[ ${#REQUIRED_FEATURES[@]} -gt 0 ]]; then
+    required_features_str=$(IFS=,; echo "${REQUIRED_FEATURES[*]}")
+else
+    required_features_str=""
+fi
+
+# Test with minimal features
+if [[ ${#REQUIRED_FEATURES[@]} -gt 0 ]]; then
+    echo "Testing $PACKAGE with required features only ($required_features_str)..."
+    (set -x; cargo clippy -p "$PACKAGE" --all-targets --no-default-features --features "$required_features_str" --profile="$PROFILE" -- -D warnings)
+else
+    echo "Testing $PACKAGE with no features..."
+    (set -x; cargo clippy -p "$PACKAGE" --all-targets --no-default-features --profile="$PROFILE" -- -D warnings)
+fi
+
+echo "Testing $PACKAGE with default features..."
+(set -x; cargo clippy -p "$PACKAGE" --all-targets --profile="$PROFILE" -- -D warnings)
+
+# Test each additional feature individually
+for feature in $features; do
+    if [[ ${#REQUIRED_FEATURES[@]} -gt 0 ]]; then
+        echo "Testing $PACKAGE with feature: $required_features_str,$feature"
+        (set -x; cargo clippy -p "$PACKAGE" --all-targets --no-default-features --features "$required_features_str,$feature" --profile="$PROFILE" -- -D warnings)
+    else
+        echo "Testing $PACKAGE with feature: $feature"
+        (set -x; cargo clippy -p "$PACKAGE" --all-targets --no-default-features --features "$feature" --profile="$PROFILE" -- -D warnings)
+    fi
+done
+
+# Test all features together
+if [[ -n "$features" ]]; then
+    all_features=$(echo $features | tr '\n' ',' | sed 's/,$//')
+    if [[ ${#REQUIRED_FEATURES[@]} -gt 0 ]]; then
+        echo "Testing $PACKAGE with all features: $required_features_str,$all_features"
+        (set -x; cargo clippy -p "$PACKAGE" --all-targets --no-default-features --features "$required_features_str,$all_features" --profile="$PROFILE" -- -D warnings)
+    else
+        echo "Testing $PACKAGE with all features: $all_features"
+        (set -x; cargo clippy -p "$PACKAGE" --all-targets --no-default-features --features "$all_features" --profile="$PROFILE" -- -D warnings)
+    fi
+fi