Clippy fixes for updates to Rust Version 2024

Signed-off-by: Simon Davies <[email protected]>

Author: simongdavies

src/hyperlight_common/src/flatbuffer_wrappers/util.rs

@@ -45,7 +45,7 @@ pub trait FlatbufferSerializable {
     fn serialize(&self, builder: &mut FlatBufferBuilder) -> FbFunctionCallResultArgs;
 }
 
-/// Implementations for basic types below
+// Implementations for basic types below
 
 impl FlatbufferSerializable for () {
     fn serialize(&self, builder: &mut FlatBufferBuilder) -> FbFunctionCallResultArgs {

src/hyperlight_host/src/mem/layout.rs

@@ -462,8 +462,7 @@ impl SandboxMemoryLayout {
 
         // Get the number of pages needed for the PTs
 
-        let num_pages: usize = ((total_mapped_memory_size + AMOUNT_OF_MEMORY_PER_PT - 1)
-            / AMOUNT_OF_MEMORY_PER_PT)
+        let num_pages: usize = total_mapped_memory_size.div_ceil(AMOUNT_OF_MEMORY_PER_PT)
             + 3; // PML4, PDPT, PD
 
         num_pages * PAGE_SIZE_USIZE

src/hyperlight_host/src/mem/mgr.rs

@@ -145,8 +145,7 @@ where
 
             let mem_size = usize::try_from(mem_size)?;
 
-            let num_pages: usize =
-                (mem_size + AMOUNT_OF_MEMORY_PER_PT - 1) / AMOUNT_OF_MEMORY_PER_PT;
+            let num_pages: usize = mem_size.div_ceil(AMOUNT_OF_MEMORY_PER_PT);
 
             // Create num_pages PT with 512 PTEs
             for p in 0..num_pages {

src/hyperlight_host/src/metrics/mod.rs

@@ -152,7 +152,7 @@ mod tests {
                 assert!(
                     matches!(
                         histogram_value,
-                        metrics_util::debugging::DebugValue::Histogram(ref histogram) if histogram.len() == 1
+                        metrics_util::debugging::DebugValue::Histogram(histogram) if histogram.len() == 1
                     ),
                     "Histogram metric does not match expected value"
                 );
@@ -169,7 +169,7 @@ mod tests {
                 assert!(
                     matches!(
                         histogram_value,
-                        metrics_util::debugging::DebugValue::Histogram(ref histogram) if histogram.len() == 1
+                        metrics_util::debugging::DebugValue::Histogram(histogram) if histogram.len() == 1
                     ),
                     "Histogram metric does not match expected value"
                 );
@@ -196,7 +196,7 @@ mod tests {
                 assert!(
                     matches!(
                         histogram_value,
-                        metrics_util::debugging::DebugValue::Histogram(ref histogram) if histogram.len() == 1
+                        metrics_util::debugging::DebugValue::Histogram(histogram) if histogram.len() == 1
                     ),
                     "Histogram metric does not match expected value"
                 );

src/hyperlight_host/src/sandbox_state/transition.rs

@@ -100,7 +100,6 @@ impl<Cur: Sandbox, Next: Sandbox> TransitionMetadata<Cur, Next> for Noop<Cur, Ne
 /// };
 /// let mutating_cb = MultiUseContextCallback::from(my_cb_fn);
 /// ```
-
 pub struct MultiUseContextCallback<'func, Cur: Sandbox, F>
 where
     F: FnOnce(&mut MultiUseGuestCallContext) -> Result<()> + 'func,
@@ -110,14 +109,14 @@ where
     cb: F,
 }
 
-impl<'a, Cur: Sandbox, Next: Sandbox, F> TransitionMetadata<Cur, Next>
-    for MultiUseContextCallback<'a, Cur, F>
+impl<Cur: Sandbox, Next: Sandbox, F> TransitionMetadata<Cur, Next>
+    for MultiUseContextCallback<'_, Cur, F>
 where
     F: FnOnce(&mut MultiUseGuestCallContext) -> Result<()>,
 {
 }
 
-impl<'a, Cur: Sandbox, F> MultiUseContextCallback<'a, Cur, F>
+impl<Cur: Sandbox, F> MultiUseContextCallback<'_, Cur, F>
 where
     F: FnOnce(&mut MultiUseGuestCallContext) -> Result<()>,
 {