Refactor dep_rust so it is re-usable in new nightly job

jsturtevant · jsturtevant · commit d37643368d59 · 2025-09-02T17:31:47.000Z
Signed-off-by: James Sturtevant &lt;jsturtevant@gmail.com&gt;
diff --git a/.github/workflows/RustNightly.yml b/.github/workflows/RustNightly.yml
@@ -0,0 +1,25 @@
+# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
+
+name: Nightly
+
+on:
+  workflow_dispatch:
+
+jobs:
+  musl:
+    strategy:
+      fail-fast: true
+      matrix:
+        hypervisor: [kvm]
+        cpu: [amd, intel]
+        config: [debug, release]
+    uses: ./.github/workflows/dep_rust.yml
+    secrets: inherit
+    with: 
+      hypervisor: ${{ matrix.hypervisor }}
+      cpu: ${{ matrix.cpu }}
+      config: ${{ matrix.config }}
+      target_triple: x86_64-unknown-linux-musl
+
+# TODO: using notification script
+
diff --git a/.github/workflows/ValidatePullRequest.yml b/.github/workflows/ValidatePullRequest.yml
@@ -44,10 +44,19 @@ jobs:
   rust:
     needs:
       - docs-pr
+    strategy:
+      fail-fast: true
+      matrix:
+        hypervisor: [hyperv, 'hyperv-ws2025', mshv, mshv3, kvm]
+        cpu: [amd, intel]
+        config: [debug, release]
     uses: ./.github/workflows/dep_rust.yml
     secrets: inherit
     with: 
       docs_only: ${{needs.docs-pr.outputs.docs-only}}
+      hypervisor: ${{ matrix.hypervisor }}
+      cpu: ${{ matrix.cpu }}
+      config: ${{ matrix.config }}
 
   fuzzing:
     needs:
diff --git a/.github/workflows/dep_rust.yml b/.github/workflows/dep_rust.yml
@@ -11,6 +11,26 @@ on:
         required: false
         type: string
         default: "false"
+      target_triple:
+        description: Target triple for cross-compilation
+        required: false
+        type: string
+        default: ""
+      hypervisor:
+        description: Hypervisor for this run (passed from caller matrix)
+        required: false
+        type: string
+        default: "kvm"
+      config:
+        description: Build configuration for this run (passed from caller matrix)
+        required: false
+        type: string
+        default: "debug"
+      cpu:
+        description: CPU architecture for the build (passed from caller matrix)
+        required: false
+        type: string
+        default: "amd"
 
 env:
   CARGO_TERM_COLOR: always
@@ -32,13 +52,8 @@ defaults:
 
 jobs:
   code-checks:
-    if: ${{ inputs.docs_only == 'false' }}
+    if: ${{ inputs.docs_only == 'false' && (inputs.hypervisor == 'hyperv-ws2025' || inputs.hypervisor == 'kvm') }}
     timeout-minutes: 60
-    strategy:
-      fail-fast: true
-      matrix:
-        hypervisor: ['hyperv-ws2025', kvm]
-        config: [debug, release]
     runs-on: ${{ fromJson(
       format('["self-hosted", "{0}", "X64", "1ES.Pool=hld-{1}-amd"]', 
         (matrix.hypervisor == 'hyperv-ws2025') && 'Windows' || 'Linux', 
@@ -63,27 +78,20 @@ jobs:
       - name: clippy
         if: ${{ (runner.os == 'Windows' )}}
         run: |
-          just clippy ${{ matrix.config }}
-          just clippy-guests ${{ matrix.config }}
+          just clippy ${{ inputs.config }} ${{ inputs.target_triple }}
+          just clippy-guests ${{ inputs.config }}
 
       - name: clippy exhaustive check
         if: ${{ (runner.os == 'Linux' )}}
         run: |
-          just clippy-exhaustive ${{ matrix.config }}
+          just clippy-exhaustive ${{ inputs.config }} ${{ inputs.target_triple }}
 
       - name: Verify MSRV
         run: ./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-guest-bin hyperlight-common
 
   build:
     if: ${{ inputs.docs_only == 'false' }}
     timeout-minutes: 60
-    strategy:
-      fail-fast: true
-      matrix:
-        hypervisor: [hyperv, 'hyperv-ws2025', mshv, mshv3, kvm] # hyperv is windows, mshv and kvm are linux
-        cpu: [amd, intel]
-        config: [debug, release]
-
     runs-on: ${{ fromJson(
         format('["self-hosted", "{0}", "X64", "1ES.Pool=hld-{1}-{2}"]', 
           (matrix.hypervisor == 'hyperv' || matrix.hypervisor == 'hyperv-ws2025') && 'Windows' || 'Linux', 
@@ -112,79 +120,77 @@ jobs:
       - name: Build and move Rust guests
         run: |
           # use these commands in favor of build-and-move-rust-guests to avoid building both configs
-          just build-rust-guests ${{ matrix.config }}
-          just move-rust-guests ${{ matrix.config }}
+          just build-rust-guests ${{ inputs.config }}
+          just move-rust-guests ${{ inputs.config }}
 
       - name: Build c guests
         run: |
           # use these commands in favor of build-and-move-c-guests to avoid building both configs
-          just build-c-guests ${{ matrix.config }}
-          just move-c-guests ${{ matrix.config }}
+          just build-c-guests ${{ inputs.config }}
+          just move-c-guests ${{ inputs.config }}
+          
       - name: Build
-        run: just build ${{ matrix.config }}
+        run: just build ${{ inputs.config }} ${{ inputs.target_triple }}
 
       - name: Run Rust tests
         env:
           CARGO_TERM_COLOR: always
         run: |
           # with default features
-          just test ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
+          just test ${{ inputs.config }} ${{ inputs.hypervisor == 'mshv' && 'mshv2' || '""'}} ${{ inputs.target_triple }}
 
           # with only one driver enabled (driver mshv/kvm feature is ignored on windows) + seccomp 
-          just test ${{ matrix.config }} seccomp,${{ matrix.hypervisor == 'mshv' && 'mshv2' || matrix.hypervisor == 'mshv3' && 'mshv3' || 'kvm' }} 
+          just test ${{ inputs.config }} seccomp,${{ inputs.hypervisor == 'mshv' && 'mshv2' || inputs.hypervisor == 'mshv3' && 'mshv3' || 'kvm' }} ${{ inputs.target_triple }}
 
           # make sure certain cargo features compile
-          cargo check -p hyperlight-host --features crashdump
-          cargo check -p hyperlight-host --features print_debug
-          cargo check -p hyperlight-host --features gdb
-          cargo check -p hyperlight-host --features trace_guest,unwind_guest,mem_profile
+          just check ${{ inputs.target_triple }}
 
           # without any features
-          just test-compilation-no-default-features ${{ matrix.config }}
+          just test-compilation-no-default-features ${{ inputs.config }} ${{ inputs.target_triple }}
 
         # One of the examples is flaky on Windows GH runners, so this allows us to disable it for now
       - name: Run Rust examples - windows
         if: ${{ (runner.os == 'Windows') }}
         env:
           CARGO_TERM_COLOR: always
           RUST_LOG: debug
-        run: just run-rust-examples ${{ matrix.config }}
+        run: just run-rust-examples ${{ inputs.config }}
 
       - name: Run Rust examples - linux
-        if: ${{ (runner.os != 'Windows') }}
+        if: false
         env:
           CARGO_TERM_COLOR: always
           RUST_LOG: debug
-        run: just run-rust-examples-linux ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
+        run: just run-rust-examples-linux ${{ inputs.config }} ${{ inputs.hypervisor == 'mshv' && 'mshv2' || '""'}} ${{ inputs.target_triple }}
 
       - name: Run Rust Gdb tests - linux
         if: runner.os == 'Linux'
         env:
           CARGO_TERM_COLOR: always
           RUST_LOG: debug
-        run: just test-rust-gdb-debugging ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
+        run: just test-rust-gdb-debugging ${{ inputs.config }} ${{ inputs.hypervisor == 'mshv' && 'mshv2' || '""'}} ${{ inputs.target_triple }}
 
       - name: Run Rust Crashdump tests
         env:
           CARGO_TERM_COLOR: always
           RUST_LOG: debug
-        run: just test-rust-crashdump ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
+        run: just test-rust-crashdump ${{ inputs.config }} ${{ inputs.hypervisor == 'mshv' && 'mshv2' || '""'}} ${{ inputs.target_triple }}
 
       - name: Run Rust Tracing tests - linux
         if: runner.os == 'Linux'
         env:
           CARGO_TERM_COLOR: always
           RUST_LOG: debug
-        run: just test-rust-tracing ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
+        run: just test-rust-tracing ${{ inputs.config }} ${{ inputs.hypervisor == 'mshv' && 'mshv2' || '""'}} ${{ inputs.target_triple }}
 
       - name: Download benchmarks from "latest"
-        run: just bench-download ${{ runner.os }} ${{ matrix.hypervisor }} ${{ matrix.cpu}} dev-latest # compare to prerelease
+        run: just bench-download ${{ runner.os }} ${{ inputs.hypervisor }} ${{ inputs.cpu}} dev-latest # compare to prerelease
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         continue-on-error: true
-        if: ${{ matrix.config == 'release' }}
+        if: ${{ inputs.config == 'release' &&  inputs.target_triple == '' }}
 
       - name: Run benchmarks
         run: |
-          just bench-ci main ${{ matrix.hypervisor == 'mshv' && 'mshv2' || ''}}
-        if: ${{ matrix.config == 'release' }}
+          just bench-ci main ${{ inputs.hypervisor == 'mshv' && 'mshv2' || ''}}
+        if: ${{ inputs.config == 'release' &&  inputs.target_triple == '' }}
