Fix windows lint errors

Signed-off-by: Simon Davies <[email protected]>

Author: simongdavies

src/hyperlight_host/src/hypervisor/hyperv_windows.rs

@@ -895,7 +895,7 @@ impl Hypervisor for HypervWindowsDriver {
     }
 
     #[cfg(crashdump)]
-    fn crashdump_context(&self) -> Result<Option<crashdump::CrashDumpContext>> {
+    fn crashdump_context(&self) -> Result<Option<crashdump::CrashDumpContext<'_>>> {
         if self.rt_cfg.guest_core_dump {
             let mut regs = [0; 27];
 

src/hyperlight_host/src/hypervisor/surrogate_process_manager.rs

@@ -531,11 +531,11 @@ mod tests {
             while result {
                 if let Ok(process_name) =
                     unsafe { CStr::from_ptr(process_entry.szExeFile.as_ptr()).to_str() }
+                    && process_name == SURROGATE_PROCESS_BINARY_NAME
                 {
-                    if process_name == SURROGATE_PROCESS_BINARY_NAME {
-                        count += 1;
-                    }
+                    count += 1;
                 }
+
                 unsafe {
                     result = Process32Next(snapshot_handle, &mut process_entry).is_ok();
                 }

src/hyperlight_host/src/hypervisor/windows_hypervisor_platform.rs

@@ -213,7 +213,7 @@ impl VMPartition {
 // with an error about a missing entrypoint
 // This function should always succeed since before we get here we have already checked that the hypervisor is present and
 // that we are on a supported version of windows.
-type WHvMapGpaRange2Func = unsafe extern "cdecl" fn(
+type WHvMapGpaRange2Func = unsafe extern "system" fn(
     WHV_PARTITION_HANDLE,
     HANDLE,
     *const c_void,
@@ -523,10 +523,10 @@ impl VMProcessor {
             );
 
             // If it failed for reasons other than insufficient buffer, return error
-            if let Err(e) = result {
-                if e.code() != windows::Win32::Foundation::WHV_E_INSUFFICIENT_BUFFER {
-                    return Err(HyperlightError::WindowsAPIError(e));
-                }
+            if let Err(e) = result
+                && e.code() != windows::Win32::Foundation::WHV_E_INSUFFICIENT_BUFFER
+            {
+                return Err(HyperlightError::WindowsAPIError(e));
             }
         }