Skip to content

Commit e29625c

Browse files
committed
Rebase and revert the code change from copilot
Signed-off-by: James Sturtevant <[email protected]>
1 parent 7bdc7d8 commit e29625c

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

.github/workflows/Fuzzing.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88
permissions:
99
id-token: write
1010
contents: read
11-
issues: write
1211

1312
jobs:
1413
fuzzing:
@@ -21,7 +20,9 @@ jobs:
2120
notify-failure:
2221
runs-on: ubuntu-latest
2322
needs: fuzzing
24-
if: failure() && needs.fuzzing.result == 'failure'
23+
if: always() && needs.fuzzing.result == 'failure'
24+
permissions:
25+
issues: write
2526
steps:
2627
- name: Checkout code
2728
uses: actions/checkout@v5

dev/notify-fuzzing-failure.sh

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ set -o pipefail
1414
## This script assumes that the gh cli is installed and in the PATH
1515
## and that there is a GitHub PAT in the GITHUB_TOKEN env var
1616
## with the following permissions:
17-
## - repo (read/write)
1817
## - issues (read/write)
1918
## or that the user is logged into the gh cli with an account with those permissions
19+
##
20+
## Run this script locally like:
21+
## GITHUB_REPOSITORY="fork/hyperlight" GITHUB_RUN_ID=1 ./dev/notify-fuzzing-failure.sh "fuzz_host_print,fuzz_guest_call,fuzz_host_call"
2022

2123
REPO="${GITHUB_REPOSITORY:-hyperlight-dev/hyperlight}"
2224
WORKFLOW_RUN_URL="${GITHUB_SERVER_URL:-https://github.com}/${REPO}/actions/runs/${GITHUB_RUN_ID:-unknown}"
@@ -91,13 +93,7 @@ if [ "$FUZZING_ISSUE_COUNT" -gt 0 ]; then
9193
**Workflow Run:** [$WORKFLOW_RUN_URL]($WORKFLOW_RUN_URL)
9294
**Fuzzing Targets:** $FUZZING_TARGETS
9395
94-
The scheduled fuzzing job has failed again. Please check the workflow logs and artifacts for details.
95-
96-
### Next Steps
97-
- [ ] Review the workflow logs for error details
98-
- [ ] Download and analyze any crash artifacts
99-
- [ ] Determine if this is a new issue or related to existing problems
100-
- [ ] Fix the underlying issue causing the fuzzing failures"
96+
The scheduled fuzzing job has failed again. Please check the workflow logs and artifacts for details."
10197

10298
# Add comment to the existing issue
10399
if gh issue comment "$ISSUE_NUMBER" --body "$COMMENT_BODY" --repo "$REPO"; then
@@ -129,7 +125,6 @@ The fuzzing workflow failed during execution. Please check the workflow logs and
129125
- [ ] Download and analyze any crash artifacts if available
130126
- [ ] Determine the root cause of the failure
131127
- [ ] Fix the underlying issue
132-
- [ ] Verify the fix by running fuzzing locally or waiting for the next scheduled run
133128
134129
### Related Documentation
135130
- [Fuzzing README](https://github.com/$REPO/blob/main/fuzz/README.md)

0 commit comments

Comments
 (0)