Remove and prevent use of assert* in hyperlight_host

Signed-off-by: Simon Davies <[email protected]>

Author: simongdavies

src/hyperlight_host/src/clippy.toml

@@ -0,0 +1,7 @@
+disallowed-macros = [
+    { path = "std::assert", reason = "no asserts in release builds" },
+    { path = "std::assert_eq", reason = "no asserts in release builds" },
+    { path = "std::assert_ne", reason = "no asserts in release builds" },
+    { path = "std::assert_true", reason = "no asserts in release builds" },
+    { path = "std::assert_false", reason = "no asserts in release builds" },
+]

src/hyperlight_host/src/lib.rs

@@ -20,6 +20,7 @@ limitations under the License.
 #![cfg_attr(not(any(test, debug_assertions)), warn(clippy::panic))]
 #![cfg_attr(not(any(test, debug_assertions)), warn(clippy::expect_used))]
 #![cfg_attr(not(any(test, debug_assertions)), warn(clippy::unwrap_used))]
+#![cfg_attr(any(test,debug_assertions),allow(clippy::disallowed_macros))]
 
 use std::sync::Once;
 

src/hyperlight_host/src/mem/shared_mem.rs

@@ -328,10 +328,13 @@ impl ExclusiveSharedMemory {
             .checked_add(2 * PAGE_SIZE_USIZE) // guard page around the memory
             .ok_or_else(|| new_error!("Memory required for sandbox exceeded usize::MAX"))?;
 
-        assert!(
-            total_size % PAGE_SIZE_USIZE == 0,
-            "shared memory must be a multiple of 4096"
-        );
+        if total_size % PAGE_SIZE_USIZE != 0 {
+            return Err(new_error!(
+                "shared memory must be a multiple of {}",
+                PAGE_SIZE_USIZE
+            ));
+        }
+
         // usize and isize are guaranteed to be the same size, and
         // isize::MAX should be positive, so this cast should be safe.
         if total_size > isize::MAX as usize {

src/hyperlight_host/src/metrics/mod.rs

@@ -259,6 +259,7 @@ fn get_histogram_opts(name: &str, help: &str, buckets: Vec<f64>) -> HistogramOpt
     opts.buckets(buckets)
 }
 
+#[allow(clippy::disallowed_macros)]
 /// Provides functionality to help with testing Hyperlight Metrics
 pub mod tests {
     use std::collections::HashSet;

src/hyperlight_host/src/sandbox/uninitialized_evolve.rs

@@ -76,7 +76,9 @@ where
 
         {
             let dispatch_function_addr = hshm.as_ref().get_pointer_to_dispatch_function()?;
-            assert_ne!(dispatch_function_addr, 0);
+            if dispatch_function_addr == 0 {
+                return Err(new_error!("Dispatch function address is null"));
+            }
             hv_handler.set_dispatch_function_addr(RawPtr::from(dispatch_function_addr))?;
         }