Skip to content

Commit eefad6f

Browse files
authored
ci: add i686 build check for hyperlight-common and hyperlight-guest (#1114)
1 parent 6d0f9af commit eefad6f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/dep_code_checks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,10 @@ jobs:
7878
- name: Verify MSRV
7979
run: ./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-guest-bin hyperlight-common
8080

81-
- name: Check hyperlight-guest builds for 32-bit (Nanvix compatibility)
81+
- name: Check 32-bit builds (Nanvix compatibility)
8282
run: |
8383
rustup target add i686-unknown-linux-gnu
84-
just check-guest-i686 debug
84+
just check-i686 debug
8585
8686
- name: Check cargo features compile
8787
run: just check

Justfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,9 @@ test-rust-tracing target=default-target features="":
200200
{{ cargo-cmd }} test -p hyperlight-common -F trace_guest --profile={{ if target == "debug" { "dev" } else { target } }} {{ target-triple-flag }}
201201
{{ cargo-cmd }} test -p hyperlight-host --profile={{ if target == "debug" { "dev" } else { target } }} {{ if features =="" {'--features trace_guest'} else { "--features trace_guest," + features } }} {{ target-triple-flag }}
202202

203-
# verify hyperlight-guest builds for 32-bit (for Nanvix compatibility - uses i686 as proxy for Nanvix's custom 32-bit x86 target)
204-
check-guest-i686 target=default-target:
203+
# verify hyperlight-common and hyperlight-guest build for 32-bit (for Nanvix compatibility - uses i686 as proxy for Nanvix's custom 32-bit x86 target)
204+
check-i686 target=default-target:
205+
cargo check -p hyperlight-common --target i686-unknown-linux-gnu --profile={{ if target == "debug" { "dev" } else { target } }}
205206
cargo check -p hyperlight-guest --target i686-unknown-linux-gnu --profile={{ if target == "debug" { "dev" } else { target } }}
206207
# Verify that trace_guest correctly fails on i686 (compile_error should trigger)
207208
! cargo check -p hyperlight-guest --target i686-unknown-linux-gnu --features trace_guest --profile={{ if target == "debug" { "dev" } else { target } }} 2>/dev/null

0 commit comments

Comments
 (0)