update remove from cart function

Author: Steph Dietz

backend/functions/assembly/crud.ts

@@ -348,30 +348,21 @@ export function decreaseQuantity(cartId: string, productId: string): string {
 
 export function removeFromCart(cartId: string, productId: string): string {
   const cartItemId = cartId + "_" + productId;
-  const cart = collections.getText(consts.cartsCollection, cartId);
-  if (cart === null || cart === "") {
-    return "Cart not found";
-  }
-  const cartItems = cart.split(",");
-
-  const newCartItems: string[] = [];
-
-  // Manually filter out the cartItemId
-  for (let i = 0; i < cartItems.length; i++) {
-    if (cartItems[i] !== productId) {
-      newCartItems.push(cartItems[i]);
-    }
-  }
-  const newCart = newCartItems.join(",");
-
   const result = collections.remove(consts.cartItemsCollection, cartItemId);
   if (!result.isSuccessful) {
     return result.error;
   }
 
-  const cartRes = collections.upsert(consts.cartsCollection, cartId, newCart);
-  if (!cartRes.isSuccessful) {
-    return cartRes.error;
+  // Fetch the current cart and update it
+  const cart = collections.getText(consts.cartsCollection, cartId);
+  const cartItems = cart.split(",").filter((item) => item !== productId);
+
+  if (cartItems.length === 0) {
+    // If the cart is empty, remove the cart from the collection
+    collections.remove(consts.cartsCollection, cartId);
+  } else {
+    // Update the cart with the remaining items
+    collections.upsert(consts.cartsCollection, cartId, cartItems.join(","));
   }
 
   return "success";